Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_kubernetes_cluster[_node_pool] - Add KataMshvVmIsolation as workload_runtime option #21176

Merged
merged 6 commits into from
Mar 31, 2023

Conversation

aristosvo
Copy link
Collaborator

@aristosvo aristosvo commented Mar 29, 2023

Fixes #21168

AccTests

  • azurerm_kubernetes_cluster test
❯ go install && make acctests SERVICE='containers' TESTARGS='-run=TestAccKubernetesCluster_nodePoolKataMshvVmIsolation'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/containers -run=TestAccKubernetesCluster_nodePoolKataMshvVmIsolation -timeout 180m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccKubernetesCluster_nodePoolKataMshvVmIsolation
=== PAUSE TestAccKubernetesCluster_nodePoolKataMshvVmIsolation
=== CONT  TestAccKubernetesCluster_nodePoolKataMshvVmIsolation
--- PASS: TestAccKubernetesCluster_nodePoolKataMshvVmIsolation (612.37s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/containers    614.317s
  • azurerm_kubernetes_cluster_node_pool test
❯ go install && make acctests SERVICE='containers' TESTARGS='-run=TestAccKubernetesClusterNodePool_workloadRuntime'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/containers -run=TestAccKubernetesClusterNodePool_workloadRuntime -timeout 180m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccKubernetesClusterNodePool_workloadRuntime
=== PAUSE TestAccKubernetesClusterNodePool_workloadRuntime
=== CONT  TestAccKubernetesClusterNodePool_workloadRuntime
--- PASS: TestAccKubernetesClusterNodePool_workloadRuntime (766.34s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/containers       768.281s

@aristosvo aristosvo changed the title azurerm_kubernetes_cluster - Add KataMshvVmIsolation as workload_runtime option azurerm_kubernetes_cluster[_node_pool] - Add KataMshvVmIsolation as workload_runtime option Mar 29, 2023
@github-actions github-actions bot added size/M and removed size/S labels Mar 29, 2023
@aristosvo aristosvo force-pushed the aks/KataMshvVmIsolation branch from b78e3b2 to 0141f0f Compare March 29, 2023 10:15
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @aristosvo this LGTM! I'll get this feature registered so we can test it and then merge once that looks good

@mbfrahry mbfrahry merged commit 1c6beb4 into hashicorp:main Mar 31, 2023
@mbfrahry mbfrahry added this to the v3.51.0 milestone Mar 31, 2023
mbfrahry added a commit that referenced this pull request Mar 31, 2023
@github-actions
Copy link

This functionality has been released in v3.51.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KataMshvVmIsolation is not supported by azurerm_kubernetes_cluster_node_pool
2 participants