Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: fixing the validation for ip_rules to include the value in the error #21178

Merged
merged 2 commits into from
Mar 30, 2023

Conversation

tombuildsstuff
Copy link
Contributor

The validation function StorageAccountIpRule is used in a Set of values which is likely to contain a number of items - as such when this returns an error we should surface exactly which value isn't valid.

This PR also adds validation to the ip_rules field for azurerm_storage_account_network_rules, since this is present for the same field in azurerm_storage_account and so should match

Fixes #21169

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tombuildsstuff tombuildsstuff merged commit 42dd928 into main Mar 30, 2023
@tombuildsstuff tombuildsstuff deleted the b/storage-account-ip-rule-validation branch March 30, 2023 07:09
tombuildsstuff added a commit that referenced this pull request Mar 30, 2023
@github-actions
Copy link

This functionality has been released in v3.50.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 1, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_storage_account.ip_rules doesn't take valid ip addresses
2 participants