New Resource: azurerm_kubernetes_cluster_extension and azurerm_arc_kubernetes_cluster_extension

[ms-zhenhua]

Swagger:

https://github.com/Azure/azure-rest-api-specs/blob/main/specification/kubernetesconfiguration/resource-manager/Microsoft.KubernetesConfiguration/stable/2022-11-01/extensions.json

Test Result:

[stephybun]

Thanks for this @ms-zhenhua but I think this should be split out into two separate resources, one for managed clusters and one for arc clusters:
azurerm_kubernetes_cluster_extension and azurerm_arc_kubernetes_cluster_extension

[ms-zhenhua]

Hi @stephybun, thank you for your suggestion and I have splitted the resource into 2 resources. Kindly take another review.
BTW, you may meet Marketplace ValidatePurchase failure error when you run TestAccKubernetesClusterExtension_plan. In this case, you need to accept the legal terms of the plan through Azure Portal or Azure Cli command.

[stephybun]

Even though there are commonalities between these resources I think the schema should just be duplicated and the resources go into arckubernetes and containers respectively. That way the testdata/scripts we use for provisioning the arc resources can be reused for the arc extension.

On the whole this is looking good and we can take another look through once all the comments have been resolved and the resources moved into the arckubernetes and containers folder.

[ms-zhenhua]

Hi @stephybun, thank you for your review. I have updated the PR and put these resources into the arckubernetes and containers folders separately. Kindly take another review.

[stephybun]

Appreciate you making those changes @ms-zhenhua and the tests are looking good! On my second pass through I picked up a few other minor things - but once those are resolved I think we should be able to merge this 🙂

[ms-zhenhua]

Hi @stephybun, thank you for reviewing. I have updated the code and document. Kindly have another look.

[stephybun]

Thanks @ms-zhenhua LGTM 🥟

[github-actions]

This functionality has been released in v3.54.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.