Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New resource: azurerm_custom_ip_prefix #21322

Merged
merged 50 commits into from
Jul 31, 2023
Merged

New resource: azurerm_custom_ip_prefix #21322

merged 50 commits into from
Jul 31, 2023

Conversation

manicminer
Copy link
Contributor

@manicminer manicminer commented Apr 6, 2023 •
edited
Loading

@manicminer manicminer self-assigned this Apr 6, 2023
@manicminer manicminer mentioned this pull request Apr 6, 2023
Closed
@manicminer manicminer marked this pull request as ready for review April 6, 2023 17:40
@manicminer manicminer requested a review from a team April 6, 2023 17:40
@manicminer manicminer modified the milestone: v3.51.0 Apr 6, 2023
@katbyte katbyte modified the milestones: v3.51.0, v3.52.0 Apr 7, 2023
jackofallops
jackofallops requested changes Apr 11, 2023
View reviewed changes
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @manicminer - I've left some comments inline below, but I'll catch up with you offline to discuss the IPv6 side of things also.

internal/services/network/custom_ip_prefix_resource.go Outdated Show resolved Hide resolved
internal/services/network/custom_ip_prefix_resource.go Show resolved Hide resolved
internal/services/network/custom_ip_prefix_resource.go Outdated Show resolved Hide resolved
internal/services/network/custom_ip_prefix_resource.go Outdated Show resolved Hide resolved
internal/services/network/custom_ip_prefix_resource.go Show resolved Hide resolved
internal/services/network/custom_ip_prefix_resource.go Outdated Show resolved Hide resolved
internal/services/network/custom_ip_prefix_resource.go Outdated Show resolved Hide resolved
internal/services/network/custom_ip_prefix_resource.go Outdated Show resolved Hide resolved
internal/services/network/custom_ip_prefix_resource.go Outdated Show resolved Hide resolved
@manicminer manicminer modified the milestones: v3.52.0, v3.53.0 Apr 13, 2023
@manicminer manicminer modified the milestones: v3.53.0, v3.54.0 Apr 20, 2023
@manicminer
Copy link
Contributor Author

Test results for IPv4

Screenshot 2023-04-25 at 12 36 13

@katbyte katbyte modified the milestones: v3.54.0, v3.55.0 Apr 28, 2023
@manicminer
Copy link
Contributor Author

Test results

Screenshot 2023-07-31 at 06 37 25

@manicminer manicminer requested a review from a team July 31, 2023 05:39
jackofallops
jackofallops approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the continued work on this one! Just a couple minor comments, but otherwise LGTM 👍

.teamcity/components/settings.kt Outdated Show resolved Hide resolved
website/docs/r/custom_ip_prefix.html.markdown Outdated Show resolved Hide resolved
@manicminer @jackofallops
Apply suggestions from code review
dfa7d62 
Co-authored-by: jackofallops <11830746+jackofallops@users.noreply.github.com>
@manicminer manicminer added this to the v3.68.0 milestone Jul 31, 2023
@manicminer manicminer merged commit bd76fac into main Jul 31, 2023
@manicminer manicminer deleted the r/custom-ip-prefix branch July 31, 2023 08:30
manicminer added a commit that referenced this pull request Jul 31, 2023
@manicminer
Changelog for #21322
25b2f92
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jackofallops jackofallops jackofallops approved these changes

Assignees

@manicminer manicminer

Labels
documentation new-resource service/network size/XL tooling
Projects
None yet
Milestone
v3.68.0
Development

Successfully merging this pull request may close these issues.
4 participants
@manicminer @jackofallops @tombuildsstuff @katbyte