Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data.azurerm_key_vault_secret - support specifying the keyvault secret version #21336

Merged
merged 2 commits into from
Apr 13, 2023

Conversation

sinbai
Copy link
Contributor

@sinbai sinbai commented Apr 7, 2023

Fix #21283.

@sinbai sinbai changed the title data.azurerm_key_vault_secret - support specifing the keyvault secret version data.azurerm_key_vault_secret - support specifying the keyvault secret version Apr 7, 2023
@@ -63,6 +63,7 @@ func (KeyVaultSecretDataSource) complete(data acceptance.TestData) string {
data "azurerm_key_vault_secret" "test" {
name = azurerm_key_vault_secret.test.name
key_vault_id = azurerm_key_vault.test.id
version = azurerm_key_vault_secret.test.version
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this acceptance test only pulls the latest version - from memory you cannot perform operations (including retrieving information about a non-current version of a Secret), so we'll need to add multiple versions of a secret to prove this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tombuildsstuff , thanks for your feedback. I have updated the code. Could you please take another look?

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔑

@katbyte katbyte merged commit 19bf1ca into hashicorp:main Apr 13, 2023
@github-actions github-actions bot added this to the v3.52.0 milestone Apr 13, 2023
katbyte added a commit that referenced this pull request Apr 13, 2023
@github-actions
Copy link

This functionality has been released in v3.52.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@sinbai sinbai deleted the keyvault/fix_issue_21283 branch March 28, 2024 02:51
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for keyvault secret versions
3 participants