Data source: azurerm_keyvault_secret - support not_before_date and expiration_date

[herquan-docusign]

Attribute not_before_date and expiration_date is already supported in resource azurerm_key_vault_secret but not supported in data source.

Here is the test I run:

 % TF_ACC=1 ARM_TEST_LOCATION=westus3 ARM_SUBSCRIPTION_ID=... ARM_TENANT_ID=... go test -v ./in
ternal/services/keyvault -run=TestAccDataSourceKeyVaultSecret_complete -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccDataSourceKeyVaultSecret_complete
=== PAUSE TestAccDataSourceKeyVaultSecret_complete
=== CONT  TestAccDataSourceKeyVaultSecret_complete

--- PASS: TestAccDataSourceKeyVaultSecret_complete (338.69s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/keyvault      338.697s

I didn't use a service principal to run this time but used the user principal instead.

[jackofallops]

Thanks @herquan-docusign - Just a couple minor changes to take a look at, but should be good to merge once those are addressed.

[jackofallops]

Thanks for making those changes @herquan-docusign - LGTM now 👍

[jackofallops]

Tests passing:

[herquan-docusign]

@jackofallops I did a rebase so we can have a clean change before merge

[jackofallops]

@jackofallops I did a rebase so we can have a clean change before merge

Thanks @herquan-docusign - This wasn't necessary in this case, you'd typically only need to do that to resolve conflicts or if you needed to pick up changes in the main branch, but we appreciate the diligence. 👍

[github-actions]

This functionality has been released in v3.52.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!