Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_monitor_metric_alert - fix using SingleResourceMultiMetricCriteria for new metric alerts regression #21658

Merged

Conversation

teowa
Copy link
Contributor

@teowa teowa commented May 5, 2023

resolves #21589
regression was introduced in https://github.com/hashicorp/terraform-provider-azurerm/pull/21392/files#diff-3bc8e0195dad4eb2f1b96e12773a17f667f2c171b427beaa0a213841c80b0765L435
fix the regression that misuse MultipleResourceMultipleMetricCriteria for legacy metric alerts and SingleResourceMultipleMetricCriteria for new metric alerts.
related to #7995

Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @teowa LGTM!

@catriona-m catriona-m merged commit d68fd11 into hashicorp:main May 5, 2023
@github-actions github-actions bot added this to the v3.56.0 milestone May 5, 2023
catriona-m added a commit that referenced this pull request May 5, 2023
@github-actions
Copy link

This functionality has been released in v3.56.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify azurerm_monitor_metric_alert for Microsoft.Sql/servers/databases fail
2 participants