Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ACI SDK to 2018-10-01. #2174

Merged
merged 1 commit into from
Oct 30, 2018
Merged

Upgrade ACI SDK to 2018-10-01. #2174

merged 1 commit into from
Oct 30, 2018

Conversation

metacpp
Copy link
Contributor

@metacpp metacpp commented Oct 29, 2018

Upgrade ACI SDK to 2018-10-01 to prepare for Virtual Network support.

Upgrade ACI SDK to `2018-10-01` to prepare for Virtual Network support in near future.
@ghost ghost added the size/L label Oct 29, 2018
@metacpp metacpp added this to the 1.19.0 milestone Oct 29, 2018
@tombuildsstuff tombuildsstuff removed this from the 1.19.0 milestone Oct 29, 2018
@metacpp
Copy link
Contributor Author

metacpp commented Oct 29, 2018

Test passed:
image

@metacpp metacpp requested a review from paultyng October 30, 2018 02:00
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff added this to the 1.18.0 milestone Oct 30, 2018
@tombuildsstuff tombuildsstuff merged commit 64544a9 into master Oct 30, 2018
@tombuildsstuff tombuildsstuff deleted the aci_upgrade branch October 30, 2018 08:53
tombuildsstuff added a commit that referenced this pull request Oct 30, 2018
@ghost
Copy link

ghost commented Mar 6, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants