New Resource : `azurerm_monitor_alert_prometheus_rule_group` #21751

sinbai · 2023-05-11T06:06:00Z

Swagger: https://github.com/Azure/azure-rest-api-specs/blob/1f449b5a17448f05ce1cd914f8ed75a0b568d130/specification/alertsmanagement/resource-manager/Microsoft.AlertsManagement/stable/2023-03-01/PrometheusRuleGroups.json#L157

Test results:

katbyte · 2023-05-17T20:15:50Z

website/docs/r/monitor_alert_prometheus_rule_group.html.markdown

+
+* `record` - (Optional) Specifies the recorded metrics name.
+
+* `resolve_configuration` - (Optional) A `resolve_configuration` block as defined below.


this might make more sense as\ ?

Suggested change

* `resolve_configuration` - (Optional) A `resolve_configuration` block as defined below.

* `alert_resolution` - (Optional) A `alert_resolution` block as defined below.

Thanks for your feedback. I have updated the code. Could you please take another look?

katbyte · 2023-05-17T20:16:48Z

website/docs/r/monitor_alert_prometheus_rule_group.html.markdown

+  scopes              = [azurerm_monitor_workspace.example.id]
+  rule {
+    enabled    = false
+    expression = "histogram_quantile(0.99, sum(rate(jobs_duration_seconds_bucket{service=\" billing-processing \"}[5m])) by (job_type))"


it might be better to use heredoc/multiple line expression here rather then escape "?

Thanks for your feedback. I have updated the code. Could you please take another look?

katbyte · 2023-05-17T20:21:00Z

internal/services/monitor/monitor_alert_prometheus_rule_group_resource.go

+
+		output.Alert = pointer.From(input.Alert)
+
+		output.Annotations = pointer.From(input.Annotations)
+
+		output.Enabled = pointer.From(input.Enabled)
+
+		output.For = pointer.From(input.For)
+
+		output.Labels = pointer.From(input.Labels)
+
+		output.Record = pointer.From(input.Record)
+
+		resolveConfigurationValue := flattenPrometheusRuleResolveConfigurationModel(input.ResolveConfiguration)
+
+		output.ResolveConfiguration = resolveConfigurationValue
+


we don't need these blank lines?

Suggested change

output.Alert = pointer.From(input.Alert)

output.Annotations = pointer.From(input.Annotations)

output.Enabled = pointer.From(input.Enabled)

output.For = pointer.From(input.For)

output.Labels = pointer.From(input.Labels)

output.Record = pointer.From(input.Record)

resolveConfigurationValue := flattenPrometheusRuleResolveConfigurationModel(input.ResolveConfiguration)

output.ResolveConfiguration = resolveConfigurationValue

output.Alert = pointer.From(input.Alert)

output.Annotations = pointer.From(input.Annotations)

output.Enabled = pointer.From(input.Enabled)

output.For = pointer.From(input.For)

output.Labels = pointer.From(input.Labels)

output.Record = pointer.From(input.Record)

resolveConfigurationValue := flattenPrometheusRuleResolveConfigurationModel(input.ResolveConfiguration)

output.ResolveConfiguration = resolveConfigurationValue

Thanks for your feedback. I have updated the code. Could you please take another look?

aristosvo · 2023-05-21T18:14:05Z

internal/services/monitor/monitor_alert_prometheus_rule_group_resource_test.go

+  location            = azurerm_resource_group.test.location
+  resource_group_name = azurerm_resource_group.test.name
+  dns_prefix          = "acctestaks%[2]d"
+  kubernetes_version  = "1.25.5"


Just passing by as I was researching azurerm_monitor_workspace and AKS Prometheus metrics, but should this kubernetes_version maybe be based on currentKubernetesVersion ?

terraform-provider-azurerm/internal/services/containers/kubernetes_cluster_resource_test.go

Line 22 in 35b106b

currentKubernetesVersion = "1.25.5"

Thanks a lot anyway for creating this resource 👍🏽

Just passing by as I was researching azurerm_monitor_workspace and AKS Prometheus metrics, but should this kubernetes_version maybe be based on currentKubernetesVersion ?

terraform-provider-azurerm/internal/services/containers/kubernetes_cluster_resource_test.go

Line 22 in 35b106b

currentKubernetesVersion = "1.25.5"

Thanks a lot anyway for creating this resource 👍🏽

Yes, kubernetes_version is value of currentKubernetesVersion. Thanks for your reminder. Per the description of kubernetes_version, If not specified, the latest recommended version will be used at provisioning time, so in all tests for resource azurerm_monitor_alert_prometheus_rule_group I removed the specified kubernetes_version to reduce dependencies. Please let me know if you have other suggestions.

sinbai · 2023-05-23T02:57:57Z

@katbyte After updating the code, all tests have passed in TeamCity as shown below. Just to let you know.

katbyte

LGTM 🌳

github-actions · 2023-05-26T08:54:22Z

This functionality has been released in v3.58.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2024-04-28T02:11:09Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions bot added dependencies documentation service/monitor size/XL labels May 11, 2023

katbyte requested changes May 17, 2023

View reviewed changes

github-actions bot added the waiting-response label May 17, 2023

aristosvo mentioned this pull request May 21, 2023

Support for Custom Azure Monitor Workspace Id for AKS #20702

Closed

1 task

aristosvo reviewed May 21, 2023

View reviewed changes

github-actions bot removed the waiting-response label May 22, 2023

sinbai added 4 commits May 23, 2023 09:16

support new resource azurerm_monitor_alert_prometheus_rule_group

7d820b8

update code

5bb538b

update code

ee7953b

update code

fa5a4d2

sinbai force-pushed the monitor/new_resource_monitor_prometheus_rule_group branch from 6e60162 to 296aa02 Compare May 23, 2023 01:26

update code

8b7cdab

sinbai force-pushed the monitor/new_resource_monitor_prometheus_rule_group branch from 296aa02 to 8b7cdab Compare May 23, 2023 01:57

katbyte approved these changes May 24, 2023

View reviewed changes

katbyte merged commit a311a2c into hashicorp:main May 24, 2023

katbyte added a commit that referenced this pull request May 24, 2023

Update CHANGELOG.md #21751

fe26e2b

github-actions bot added this to the v3.58.0 milestone May 24, 2023

sinbai deleted the monitor/new_resource_monitor_prometheus_rule_group branch March 28, 2024 02:50

github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Resource : `azurerm_monitor_alert_prometheus_rule_group` #21751

New Resource : `azurerm_monitor_alert_prometheus_rule_group` #21751

sinbai commented May 11, 2023 •

edited

Loading

katbyte May 17, 2023

sinbai May 23, 2023

katbyte May 17, 2023

sinbai May 23, 2023

katbyte May 17, 2023

sinbai May 23, 2023

aristosvo May 21, 2023 •

edited

Loading

sinbai May 23, 2023

sinbai commented May 23, 2023

katbyte left a comment

github-actions bot commented May 26, 2023

github-actions bot commented Apr 28, 2024


		* `record` - (Optional) Specifies the recorded metrics name.

		* `resolve_configuration` - (Optional) A `resolve_configuration` block as defined below.

	* `resolve_configuration` - (Optional) A `resolve_configuration` block as defined below.
	* `alert_resolution` - (Optional) A `alert_resolution` block as defined below.

New Resource : azurerm_monitor_alert_prometheus_rule_group #21751

New Resource : azurerm_monitor_alert_prometheus_rule_group #21751

Conversation

sinbai commented May 11, 2023 • edited Loading

katbyte May 17, 2023

Choose a reason for hiding this comment

sinbai May 23, 2023

Choose a reason for hiding this comment

katbyte May 17, 2023

Choose a reason for hiding this comment

sinbai May 23, 2023

Choose a reason for hiding this comment

katbyte May 17, 2023

Choose a reason for hiding this comment

sinbai May 23, 2023

Choose a reason for hiding this comment

aristosvo May 21, 2023 • edited Loading

Choose a reason for hiding this comment

sinbai May 23, 2023

Choose a reason for hiding this comment

sinbai commented May 23, 2023

katbyte left a comment

Choose a reason for hiding this comment

github-actions bot commented May 26, 2023

github-actions bot commented Apr 28, 2024

New Resource : `azurerm_monitor_alert_prometheus_rule_group` #21751

New Resource : `azurerm_monitor_alert_prometheus_rule_group` #21751

sinbai commented May 11, 2023 •

edited

Loading

aristosvo May 21, 2023 •

edited

Loading