azurerm_sentinel_data_connector_microsoft_threat_intelligence: deprecate bing_safety_phishing_url_lookback_date

[ziyeqf]

deprecate it as API no longer support it.

test

❯ tftest sentinel TestAccSentinelDataConnectorMicrosoftThreatIntelligence
=== RUN   TestAccSentinelDataConnectorMicrosoftThreatIntelligence_basic
=== PAUSE TestAccSentinelDataConnectorMicrosoftThreatIntelligence_basic
=== RUN   TestAccSentinelDataConnectorMicrosoftThreatIntelligence_complete
=== PAUSE TestAccSentinelDataConnectorMicrosoftThreatIntelligence_complete
=== CONT  TestAccSentinelDataConnectorMicrosoftThreatIntelligence_basic
=== CONT  TestAccSentinelDataConnectorMicrosoftThreatIntelligence_complete
--- PASS: TestAccSentinelDataConnectorMicrosoftThreatIntelligence_basic (138.94s)
--- PASS: TestAccSentinelDataConnectorMicrosoftThreatIntelligence_complete (187.07s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/sentinel      187.119s

[mbfrahry]

Nearly there, I just believe there is duplicate code that can be removed

[ziyeqf]

have changed microsoft_emerging_threat_feed_lookback_date from optional to required, it seems to be breaking change but it's indeed required by service, without it this resource could not be created

[mbfrahry]

Nearly there but we can sidestep the breaking change through the FourPointOh flag

[mbfrahry]

As this is a breaking change, let's set Required/Optional by the FourPointOh feature flag. We also need to update the docs to say this is Required now

[mbfrahry]

LGTM! Thanks for making those changes @ziyeqf

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.