Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_network_function_azure_traffic_collector #22274

Merged
merged 6 commits into from
Jul 25, 2023

Conversation

ms-zhenhua
Copy link
Contributor

@ms-zhenhua ms-zhenhua commented Jun 25, 2023

Swagger:

https://github.com/Azure/azure-rest-api-specs/blob/de93ae3897babd397a59d3c9dcb894855d0db1c3/specification/networkfunction/resource-manager/Microsoft.NetworkFunction/stable/2022-11-01/AzureTrafficCollector.json#L150

Notes: This resource is supported in the following regions only:
westus,eastus,northcentralus,southcentralus,centralus,eastus2,westcentralus,westus2,westus3

Before running testcases, please make sure Microsoft.NetworkFunction is registered in your subscription.
image

Test Result:

image

--- PASS: TestAccNetworkFunctionAzureTrafficCollector_basic (811.97s)
--- PASS: TestAccNetworkFunctionAzureTrafficCollector_complete (841.93s)
--- PASS: TestAccNetworkFunctionAzureTrafficCollector_update (866.12s)
--- PASS: TestAccNetworkFunctionAzureTrafficCollector_requiresImport (873.66s)
PASS
ok github.com/hashicorp/terraform-provider-azurerm/internal/services/networkfunction 884.946s

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦉

@katbyte katbyte merged commit b282d23 into hashicorp:main Jul 25, 2023
katbyte added a commit that referenced this pull request Jul 25, 2023
@github-actions github-actions bot added this to the v3.67.0 milestone Jul 25, 2023
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants