azurerm_web_application_firewall_policy：support log_scrubbing property
#22522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wuxu92
commented
Jul 14, 2023
•
wuxu92
commented
wuxu92
force-pushed
the
webappfirewall/logscrubbing
branch
from
01ed5b8 to
200f3ae
Compare
wuxu92
changed the title
azurerm_web_application_firewall_policy：suports log_scrubbing propertyazurerm_web_application_firewall_policy：support log_scrubbing property
katbyte
approved these changes
Aug 1, 2023
Comment on lines
383
to
413
| }, | ||
| "rule": { | ||
| Type: pluginsdk.TypeList, | ||
| Optional: true, | ||
| Elem: &pluginsdk.Resource{ | ||
| Schema: map[string]*pluginsdk.Schema{ | ||
| "enabled": { | ||
| Type: pluginsdk.TypeBool, | ||
| Optional: true, | ||
| Default: true, | ||
| }, | ||
| "match_variable": { | ||
| Type: pluginsdk.TypeString, | ||
| Required: true, | ||
| ValidateFunc: validation.StringInSlice( | ||
| webapplicationfirewallpolicies.PossibleValuesForScrubbingRuleEntryMatchVariable(), | ||
| false), | ||
| }, | ||
| "selector_match_operator": { | ||
| Type: pluginsdk.TypeString, | ||
| Optional: true, | ||
| Default: "Equals", | ||
| ValidateFunc: validation.StringInSlice( | ||
| webapplicationfirewallpolicies.PossibleValuesForScrubbingRuleEntryMatchOperator(), | ||
| false), | ||
| }, | ||
| "selector": { | ||
| Type: pluginsdk.TypeString, | ||
| Optional: true, | ||
| Description: "When matchVariable is a collection, operator used to specify which elements in the collection this rule applies to.", | ||
| }, |
There was a problem hiding this comment.
could we use whitespace?
Suggested change
| }, | |
| "rule": { | |
| Type: pluginsdk.TypeList, | |
| Optional: true, | |
| Elem: &pluginsdk.Resource{ | |
| Schema: map[string]*pluginsdk.Schema{ | |
| "enabled": { | |
| Type: pluginsdk.TypeBool, | |
| Optional: true, | |
| Default: true, | |
| }, | |
| "match_variable": { | |
| Type: pluginsdk.TypeString, | |
| Required: true, | |
| ValidateFunc: validation.StringInSlice( | |
| webapplicationfirewallpolicies.PossibleValuesForScrubbingRuleEntryMatchVariable(), | |
| false), | |
| }, | |
| "selector_match_operator": { | |
| Type: pluginsdk.TypeString, | |
| Optional: true, | |
| Default: "Equals", | |
| ValidateFunc: validation.StringInSlice( | |
| webapplicationfirewallpolicies.PossibleValuesForScrubbingRuleEntryMatchOperator(), | |
| false), | |
| }, | |
| "selector": { | |
| Type: pluginsdk.TypeString, | |
| Optional: true, | |
| Description: "When matchVariable is a collection, operator used to specify which elements in the collection this rule applies to.", | |
| }, | |
| }, | |
| "rule": { | |
| Type: pluginsdk.TypeList, | |
| Optional: true, | |
| Elem: &pluginsdk.Resource{ | |
| Schema: map[string]*pluginsdk.Schema{ | |
| "enabled": { | |
| Type: pluginsdk.TypeBool, | |
| Optional: true, | |
| Default: true, | |
| }, | |
| "match_variable": { | |
| Type: pluginsdk.TypeString, | |
| Required: true, | |
| ValidateFunc: validation.StringInSlice( | |
| webapplicationfirewallpolicies.PossibleValuesForScrubbingRuleEntryMatchVariable(), | |
| false), | |
| }, | |
| "selector_match_operator": { | |
| Type: pluginsdk.TypeString, | |
| Optional: true, | |
| Default: "Equals", | |
| ValidateFunc: validation.StringInSlice( | |
| webapplicationfirewallpolicies.PossibleValuesForScrubbingRuleEntryMatchOperator(), | |
| false), | |
| }, | |
| "selector": { | |
| Type: pluginsdk.TypeString, | |
| Optional: true, | |
| Description: "When matchVariable is a collection, operator used to specify which elements in the collection this rule applies to.", | |
| }, |
between properties?
There was a problem hiding this comment.
thanks! updated with whitespace lines
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.