Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_maintenance_configuration: Read function sets to wrong named properties #22555

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Jul 17, 2023

Change the code to match the schema and the document. Otherwise, the read returns:

| 2023/07/17 15:22:38 setting install_patches: Invalid address to set: []string{"install_patches", "0", "linux", "0", "packages_to_exclude"}:

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @magodo LGTM 🍋

@stephybun stephybun merged commit d2f230e into hashicorp:main Jul 17, 2023
@github-actions github-actions bot added this to the v3.66.0 milestone Jul 17, 2023
stephybun added a commit that referenced this pull request Jul 17, 2023
@snakeskin
Copy link

I see the behaviour is not idempotent: each apply action adds the entry to package_names_mask_to_exclude
Also I that values from package_names_mask_to_exclude copied to package_names_mask_to_include:
` ~ install_patches {
# (1 unchanged attribute hidden)

      ~ linux {
          ~ package_names_mask_to_exclude = [
              + "mongodb*",
            ]
          ~ package_names_mask_to_include = [
              - "mongodb*",
            ]
            # (1 unchanged attribute hidden)
        }
    }`

In my case above I don't set package_names_mask_to_include value.

@tombuildsstuff
Copy link
Contributor

hey @snakeskin

Thanks for reporting this, taking a look through here it appears that the include and exclude fields are being set incorrectly - so I've opened #22671 to fix that, which'll ship in this week's release.

Thanks!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants