Auto PR: Regenerating based on (c5fafec787a50c2a4a9200291bc2409535b5f5bf) #22647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+20
to
+76
| resource "azurerm_application_insights" "example" { | ||
| name = "example" | ||
| location = azurerm_resource_group.example.location | ||
| resource_group_name = azurerm_resource_group.example.name | ||
| application_type = "example-value" | ||
| } | ||
| data "azurerm_client_config" "test" {} | ||
| resource "azurerm_key_vault" "example" { | ||
| name = "example" | ||
| location = azurerm_resource_group.example.location | ||
| resource_group_name = azurerm_resource_group.example.name | ||
| tenant_id = data.azurerm_client_config.example.tenant_id | ||
| sku_name = "example-value" | ||
| soft_delete_retention_days = "example-value" | ||
| } | ||
| resource "azurerm_key_vault_access_policy" "example" { | ||
| key_vault_id = azurerm_key_vault.example.id | ||
| tenant_id = data.azurerm_client_config.example.tenant_id | ||
| object_id = data.azurerm_client_config.example.object_id | ||
| key_permissions = "example-value" | ||
| } | ||
| resource "azurerm_kubernetes_cluster" "example" { | ||
| name = "example" | ||
| location = azurerm_resource_group.example.location | ||
| resource_group_name = azurerm_resource_group.example.name | ||
| dns_prefix = "acctestaksexample" | ||
| default_node_pool { | ||
| name = "example-value" | ||
| node_count = "example-value" | ||
| vm_size = "example-value" | ||
| } | ||
| identity { | ||
| type = "example-value" | ||
| } | ||
| } | ||
| resource "azurerm_machine_learning_workspace" "example" { | ||
| name = "example" | ||
| location = azurerm_resource_group.example.location | ||
| resource_group_name = azurerm_resource_group.example.name | ||
| key_vault_id = azurerm_key_vault.example.id | ||
| storage_account_id = azurerm_storage_account.example.id | ||
| application_insights_id = azurerm_application_insights.example.id | ||
| identity { | ||
| type = "example-value" | ||
| } | ||
| } | ||
| resource "azurerm_resource_group" "example" { | ||
| name = "example-resources" | ||
| location = "West Europe" | ||
| } | ||
| resource "azurerm_storage_account" "example" { | ||
| name = "example" | ||
| location = azurerm_resource_group.example.location | ||
| resource_group_name = azurerm_resource_group.example.name | ||
| account_tier = "example-value" | ||
| account_replication_type = "example-value" | ||
| } |
There was a problem hiding this comment.
minor, but why are the dependencies ordered alphabetically here?
|
|
||
| The following arguments are supported: | ||
|
|
||
| * `kubernetes_cluster_id` - (Required) Specifies the Kubernetes Cluster Id within which this Kubernetes Cluster Trusted Access Role Binding should exist. Changing this forces a new Kubernetes Cluster Trusted Access Role Binding to be created. |
There was a problem hiding this comment.
this should become:
Suggested change
| * `kubernetes_cluster_id` - (Required) Specifies the Kubernetes Cluster Id within which this Kubernetes Cluster Trusted Access Role Binding should exist. Changing this forces a new Kubernetes Cluster Trusted Access Role Binding to be created. | |
| * `kubernetes_cluster_id` - (Required) Specifies the ID of the Kubernetes Cluster within which this Trusted Access Role Binding should exist. Changing this forces a new Kubernetes Cluster Trusted Access Role Binding to be created. |
|
|
||
| * `roles` - (Required) A list of roles to bind, each item is a resource type qualified role name. | ||
|
|
||
| * `source_resource_id` - (Required) The ARM resource ID of source resource that trusted access is configured for. Changing this forces a new Kubernetes Cluster Trusted Access Role Binding to be created. |
There was a problem hiding this comment.
this should become:
Suggested change
| * `source_resource_id` - (Required) The ARM resource ID of source resource that trusted access is configured for. Changing this forces a new Kubernetes Cluster Trusted Access Role Binding to be created. | |
| * `source_resource_id` - (Required) The ID of the source resource that trusted access is configured for. Changing this forces a new Kubernetes Cluster Trusted Access Role Binding to be created. |
| "kubernetes_cluster_id": { | ||
| ForceNew: true, | ||
| Required: true, | ||
| Type: pluginsdk.TypeString, |
There was a problem hiding this comment.
since we know what the Parent Resource ID is, can we add validation to check this is correct?
|
Tests pass: 
|
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regenerating the Terraform Provider based on the latest changes