Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eventgrid: refactoring to use hashicorp/go-azure-sdk #22673

Merged
merged 14 commits into from
Aug 2, 2023

Conversation

tombuildsstuff
Copy link
Contributor

This PR refactors the eventgrid package to make use of hashicorp/go-azure-sdk rather than Azure/azure-sdk-for-go - this also makes use of a Meta Client for convenience purposes.

@tombuildsstuff
Copy link
Contributor Author

Tests pass:

Screenshot 2023-08-02 at 17 23 58

@tombuildsstuff tombuildsstuff force-pushed the refactor/eventgrid-to-go-azure-sdk branch from df53b36 to f1ad61b Compare August 2, 2023 15:32
Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@tombuildsstuff
Copy link
Contributor Author

tombuildsstuff commented Aug 2, 2023

Tests pass:
Screenshot 2023-08-02 at 18 22 10

@tombuildsstuff tombuildsstuff merged commit ca202db into main Aug 2, 2023
@tombuildsstuff tombuildsstuff deleted the refactor/eventgrid-to-go-azure-sdk branch August 2, 2023 16:20
tombuildsstuff added a commit that referenced this pull request Aug 2, 2023
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants