Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_recovery_services_protected_vm can now be used when VM's are in a different resource group #2287

Merged
merged 2 commits into from
Nov 12, 2018
Merged

azurerm_recovery_services_protected_vm can now be used when VM's are in a different resource group #2287

merged 2 commits into from
Nov 12, 2018

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Nov 9, 2018 •
edited
Loading

Fixes #2215

@katbyte katbyte added this to the 1.19.0 milestone Nov 9, 2018
@katbyte katbyte requested a review from a team November 9, 2018 23:46
@ghost ghost added the size/M label Nov 9, 2018
@katbyte katbyte mentioned this pull request Nov 9, 2018
Closed
@katbyte
Copy link
Collaborator Author

katbyte commented Nov 9, 2018

Tests pass:

==> Fixing source code with gofmt...
gofmt -s -w ./azurerm
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./azurerm -v -test.run=TestAccAzureRMRecoveryServicesProtectedVm -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMRecoveryServicesProtectedVm_basic
=== PAUSE TestAccAzureRMRecoveryServicesProtectedVm_basic
=== RUN   TestAccAzureRMRecoveryServicesProtectedVm_separateResourceGroups
--- PASS: TestAccAzureRMRecoveryServicesProtectedVm_separateResourceGroups (688.47s)
=== CONT  TestAccAzureRMRecoveryServicesProtectedVm_basic
--- PASS: TestAccAzureRMRecoveryServicesProtectedVm_basic (669.43s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	1358.356s

@katbyte katbyte mentioned this pull request Nov 9, 2018
Closed
tombuildsstuff
tombuildsstuff approved these changes Nov 10, 2018
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM 👍

azurerm/resource_arm_recovery_services_protected_vm_test.go Outdated
@@ -259,3 +297,51 @@ resource "azurerm_recovery_services_protected_vm" "test" {

`, testAccAzureRMRecoveryServicesProtectedVm_base(rInt, location))
}

func testAbcAzureRMRecoveryServicesProtectedVm_additionalVault(rInt int, location string) string {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Abc?

azurerm/resource_arm_recovery_services_protected_vm_test.go Outdated
`, testAccAzureRMRecoveryServicesProtectedVm_base(rInt, location), rInt, location)
}

func testAbcAzureRMRecoveryServicesProtectedVm_separateResourceGroups(rInt int, location string) string {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Abc?

@katbyte katbyte merged commit 43d538f into master Nov 12, 2018
@katbyte katbyte deleted the b-recoveryservices-multirg branch November 12, 2018 01:33
katbyte added a commit that referenced this pull request Nov 12, 2018
@katbyte
Update CHANGELOG.md to include #2287
2a09036
@ghost
Copy link

ghost commented Mar 6, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
bug service/recovery-services size/M
Projects
None yet
Milestone
v1.19.0
Development

Successfully merging this pull request may close these issues.
2 participants
@katbyte @tombuildsstuff