Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_pim_active_role_assignment: fix timeout for wait state, timeout from ctx #22932

Merged
merged 1 commit into from
Sep 1, 2023
Merged

azurerm_pim_active_role_assignment: fix timeout for wait state, timeout from ctx #22932

merged 1 commit into from
Sep 1, 2023

Conversation

wuxu92
Copy link
Contributor

@wuxu92 wuxu92 commented Aug 14, 2023 •
edited
Loading

fixes #22909.

this PR is a supplement to #22682 which only fixes part of resources.

--- PASS: TestAccPimActiveRoleAssignment_requiresImport (361.92s)
--- PASS: TestAccPimActiveRoleAssignment_expirationByDateConfig (367.84s)
--- PASS: TestAccPimActiveRoleAssignment_update (599.70s)
--- PASS: TestAccPimActiveRoleAssignment_expirationByDurationDaysConfig (658.57s)
--- PASS: TestAccPimActiveRoleAssignment_expirationByDurationHoursConfig (673.04s)
PASS

@wuxu92 wuxu92 changed the title azurerm_pim_active_role_assignment: azurerm_pim_active_role_assignment: fix timeout for wait state, timeout from ctx Aug 15, 2023
@davidng1996
Copy link

davidng1996 commented Aug 16, 2023 •
edited
Loading

@wuxu92 looks like this is the same changes that you have done for azurerm_pim_eligible_role_assignment in this PR #22682 and it is not really fixing the issue stated in #22909. The code will still fails even though they are created and can be found in Azure Portal

@rcskosir rcskosir mentioned this pull request Aug 29, 2023
Closed
1 task
tombuildsstuff
tombuildsstuff approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff merged commit 27b4afc into hashicorp:main Sep 1, 2023
@tombuildsstuff tombuildsstuff added this to the v3.72.0 milestone Sep 1, 2023
tombuildsstuff added a commit that referenced this pull request Sep 1, 2023
@tombuildsstuff
updating to include #22932
1785115
@wuxu92 wuxu92 deleted the pim/activeassigntimeout branch September 1, 2023 23:40
@ChrisTav424 ChrisTav424 mentioned this pull request Nov 3, 2023
Open
1 task
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
service/authorization size/XS
Projects
None yet
Milestone
v3.72.0
Development

Successfully merging this pull request may close these issues.

azurerm_pim_active_role_assignment issues not fixed in #22730 and #22588
3 participants
@wuxu92 @davidng1996 @tombuildsstuff