New resource azurerm_iothub_endpoint_cosmosdb_account
#23065
Conversation
|
Test result |
There was a problem hiding this comment.
Thanks for this @myc2h6o - this is looking pretty good, I've left a couple of minor comments but can have another look once those get fixed up. Thanks!
| } | ||
|
|
||
| endpoint.PrimaryKey = pointer.To(state.PrimaryKey) | ||
| endpoint.SecondaryKey = pointer.To(state.PrimaryKey) |
There was a problem hiding this comment.
| endpoint.SecondaryKey = pointer.To(state.PrimaryKey) | |
| endpoint.SecondaryKey = pointer.To(state.SecondaryKey) |
There was a problem hiding this comment.
thanks for pointing this out! I've fixed it
| iothub, err := client.Get(ctx, id.ResourceGroup, id.IotHubName) | ||
| if err != nil { | ||
| if utils.ResponseWasNotFound(iothub.Response) { | ||
| return nil |
There was a problem hiding this comment.
should we return an error here?
There was a problem hiding this comment.
have added the error return
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Close #20591