Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade network SDK to 2018-08-01 #2433

Merged
merged 10 commits into from
Dec 18, 2018
Merged

Upgrade network SDK to 2018-08-01 #2433

merged 10 commits into from
Dec 18, 2018

Conversation

metacpp
Copy link
Contributor

@metacpp metacpp commented Dec 3, 2018 •
edited
Loading

This PR is to upgrade network SDK to 2018-08-01, which supports network_profile and subnet_delegation.

Due to the change by Azure API in 2018-08-01, internal_public_ip_address_id is being deprecated by public_ip_address_id.

@metacpp
⬆️ (Azure Network Go package.) Upgrade to 2018-08-01 for network pa…
3624b3e 
…ckage.

Upgrade to `2018-08-01` for network package to prepare for network profile for ACI.
@ghost ghost added the size/XXL label Dec 3, 2018
WodansSon
WodansSon approved these changes Dec 4, 2018
View reviewed changes
Copy link
Collaborator

@WodansSon WodansSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@metacpp Thanks for the PR, mostly looks good... left a couple of super minor comments. Thanks!

azurerm/helpers/azure/firewall.go Outdated Show resolved Hide resolved
azurerm/helpers/azure/firewall.go Show resolved Hide resolved
@hbuckle
Copy link
Contributor

hbuckle commented Dec 4, 2018

FYI, the firewall resource was originally written against the preview API so definitely needs some work to update to the latest. I think internal_public_ip_address_id should be renamed to public_ip_address_id as this is what it's now called. The ICMP protocol was removed and readded to the specs for some reason, so that may not have made it into the latest SDK.
There are also some workarounds in the code for issues in the preview API that can be removed.

I have started work on all this as well as application rules, not sure how long it will take me to finish at the moment though.

@katbyte
Copy link
Collaborator

katbyte commented Dec 4, 2018

I agree with @hbuckle. If public_ip_address_id is now the correct name of the field then it should definitely be renamed to match, internal_public_ip_address_id is a bit of a weird claim 🤔

WodansSon and others added 2 commits December 4, 2018 09:09
@WodansSon @metacpp
Update InternalPublicIPAddress to PublicIPAddress
6754216 
Co-Authored-By: metacpp <1684739+metacpp@users.noreply.github.com>
@metacpp
Re-add ICMP and change to public_ip_address_id.
c865fb1
@metacpp
Copy link
Contributor Author

metacpp commented Dec 4, 2018

I agree with @hbuckle. If public_ip_address_id is now the correct name of the field then it should definitely be renamed to match, internal_public_ip_address_id is a bit of a weird claim 🤔

I just updated the PR, please help with taking a look at it.

@metacpp metacpp added this to the 1.20.0 milestone Dec 4, 2018
@katbyte katbyte mentioned this pull request Dec 7, 2018
Closed
@katbyte katbyte modified the milestones: 1.20.0, 1.21.0 Dec 7, 2018
@metacpp
Copy link
Contributor Author

metacpp commented Dec 7, 2018 •
edited
Loading

@katbyte @tombuildsstuff just resolved the comments and updated the PRs, please help with reviewing these changes.

metacpp
metacpp commented Dec 11, 2018
View reviewed changes
azurerm/resource_arm_firewall_test.go
),
},
{
Config: testAccAzureRMFirewall_basic(ri, location),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@katbyte thanks for adding more tests. I've a question here: is this test step duplicated with TestAccAzureRMFirewall_basic ? I suppose that each test step is actually isolated one.

@hbuckle hbuckle mentioned this pull request Dec 14, 2018
Closed
katbyte
katbyte approved these changes Dec 18, 2018
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @metacpp 👍

@katbyte katbyte merged commit c42061c into master Dec 18, 2018
@katbyte katbyte deleted the nw_upgrade branch December 18, 2018 02:28
katbyte added a commit that referenced this pull request Dec 18, 2018
@katbyte
Updating CHANGELOG.md to include #2433
8518070
@metacpp metacpp mentioned this pull request Jan 25, 2019
Closed
@ghost
Copy link

ghost commented Mar 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hbuckle hbuckle hbuckle left review comments

@tombuildsstuff tombuildsstuff tombuildsstuff left review comments

@WodansSon WodansSon WodansSon approved these changes

@katbyte katbyte katbyte approved these changes

@JunyiYi JunyiYi Awaiting requested review from JunyiYi

Assignees
No one assigned
Labels
enhancement size/XXL
Projects
None yet
Milestone
v1.21.0
Development

Successfully merging this pull request may close these issues.
6 participants
@metacpp @hbuckle @katbyte @tombuildsstuff @JunyiYi @WodansSon