Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_data_protection_backup_vault - ZoneRedundancy option not accepted #24530

Closed
1 task done
marcelloformica opened this issue Jan 17, 2024 · 5 comments · Fixed by #24556
Closed
1 task done

azurerm_data_protection_backup_vault - ZoneRedundancy option not accepted #24530

marcelloformica opened this issue Jan 17, 2024 · 5 comments · Fixed by #24556

Comments

@marcelloformica
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment and review the contribution guide to help.

Terraform Version

1.6.6

AzureRM Provider Version

3.87.0

Affected Resource(s)/Data Source(s)

azurerm_data_protection_backup_vault

Terraform Configuration Files

resource "azurerm_data_protection_backup_vault" "bvault" {
  provider = azurerm.lz
  name                          = var.bvault_name
  location                      = var.bvault_location
  resource_group_name           = var.bvault_rg_name
  redundancy                    = var.bvault_redundancy
  datastore_type                = "VaultStore"
}

Debug Output/Panic Output

N/A

Expected Behaviour

azurerm_data_protection_backup_vault should support also zone redundancy, besides GeoRedundant and LocallyRedundant types, so that we have a feature parity with (for example), creation from Azure Portal.

In #21300 it was explained that this requires API version bump from 2022-04-01 to 2023-01-01; I see that this version upgrade has been done later, in #24143, is anything else required to allow this redundancy type?

Actual Behaviour

Error: expected redundancy to be one of ["GeoRedundant" "LocallyRedundant"], got ZoneRedundant

Steps to Reproduce

terraform apply of the above sample code, passing 'ZoneRedundant' as value for var.bvault_redundancy

Important Factoids

No response

References

#21300
#24143

@rcskosir
Copy link
Contributor

Thanks for taking the time to submit this issue. I do see that the version was updated in #24143, which means that the original enhancement request in #21300 is no longer blocked by a version update. We like to try to keep discussions consolidated, so we’re going to close this new issue in favor of #21300 since the two issues are asking for the same enhancement.

@rcskosir rcskosir closed this as not planned Won't fix, can't repro, duplicate, stale Jan 18, 2024
@rcskosir
Copy link
Contributor

*changed the closure type to match duplicate

@sinbai
Copy link
Contributor

sinbai commented Jan 19, 2024

Hi @marcelloformica I have submitted PR #24556 to support ZoneRedundancy for azurerm_data_protection_backup_vault. Could you please track it for more updates?

@github-actions github-actions bot added this to the v3.89.0 milestone Jan 19, 2024
Copy link

This functionality has been released in v3.89.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants