Provider function to replace validation.NoZeroValues #2467
Conversation
azurerm/helpers/validate/strings.go
Outdated
|
|
||
| newv := strings.TrimSpace(v) | ||
|
|
||
| if len(newv) == 0 { |
There was a problem hiding this comment.
this could be:
if strings.TrimSpace(v) == "" {There was a problem hiding this comment.
Yep... doesn't make sense to spin up a new var when you can do it inline.
Co-Authored-By: jeffreyCline <jcline@microsoft.com>
Co-Authored-By: jeffreyCline <jcline@microsoft.com>
Co-Authored-By: jeffreyCline <jcline@microsoft.com>
Co-Authored-By: jeffreyCline <jcline@microsoft.com>
Co-Authored-By: jeffreyCline <jcline@microsoft.com>
There was a problem hiding this comment.
one minor thing in addition to @katbyte's comments but this otherwise LGTM 👍
| Value: "1 ", | ||
| TestName: "OneSpace", | ||
| ErrCount: 0, | ||
| }, |
There was a problem hiding this comment.
it'd be good to add a test case for 5 empty spaces in here too
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Fixes #2462