azurerm_private_endpoint - ensure update does not remove azurerm_private_endpoint_application_security_group_association (#24843)

[bPhysicist]

Fixes #24843

Bug summary

A subsequent update of a azurerm_private_endpoint removes all ApplicationSecurityGroupAssociations. This conflicts with azurerm_private_endpoint_application_security_group_association as it removes it without any warning or error message.

Solution description

I added a get request to the update method of the azurerm_private_endpoint resource in order to fetch ApplicationSecurityGroupAssociations and attach them to the update request.
The added TestCase catches this bug.

Test outpus

$ make acctests SERVICE=network TESTARGS='-run="^(TestAccDataSourcePrivateEndpointConnection|TestAccPrivateEndpointApplic
ationSecurityGroupAssociationResource|TestAccPrivateEndpoint)"' TESTTIMEOUT='60m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/network -run="^(TestAccDataSourcePrivateEndpointConnection|TestAccPrivateEndpointApplicationSecurityGroupAssociationResource|TestAccPrivateEndpoint)" -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccPrivateEndpointApplicationSecurityGroupAssociationResource_basic
=== PAUSE TestAccPrivateEndpointApplicationSecurityGroupAssociationResource_basic
=== RUN   TestAccPrivateEndpointApplicationSecurityGroupAssociationResource_updatePrivateEndpoint
=== PAUSE TestAccPrivateEndpointApplicationSecurityGroupAssociationResource_updatePrivateEndpoint
=== RUN   TestAccPrivateEndpointApplicationSecurityGroupAssociationResource_requiresImport
=== PAUSE TestAccPrivateEndpointApplicationSecurityGroupAssociationResource_requiresImport
=== RUN   TestAccPrivateEndpointApplicationSecurityGroupAssociationResource_deleted
=== PAUSE TestAccPrivateEndpointApplicationSecurityGroupAssociationResource_deleted
=== RUN   TestAccDataSourcePrivateEndpointConnection_complete
=== PAUSE TestAccDataSourcePrivateEndpointConnection_complete
=== RUN   TestAccPrivateEndpoint_basic
=== PAUSE TestAccPrivateEndpoint_basic
=== RUN   TestAccPrivateEndpoint_updateTag
=== PAUSE TestAccPrivateEndpoint_updateTag
=== RUN   TestAccPrivateEndpoint_updateNicName
=== PAUSE TestAccPrivateEndpoint_updateNicName
=== RUN   TestAccPrivateEndpoint_requestMessage
=== PAUSE TestAccPrivateEndpoint_requestMessage
=== RUN   TestAccPrivateEndpoint_privateDnsZoneGroup
=== PAUSE TestAccPrivateEndpoint_privateDnsZoneGroup
=== RUN   TestAccPrivateEndpoint_privateDnsZoneRename
=== PAUSE TestAccPrivateEndpoint_privateDnsZoneRename
=== RUN   TestAccPrivateEndpoint_privateDnsZoneUpdate
=== PAUSE TestAccPrivateEndpoint_privateDnsZoneUpdate
=== RUN   TestAccPrivateEndpoint_statiIpAddress
=== PAUSE TestAccPrivateEndpoint_statiIpAddress
=== RUN   TestAccPrivateEndpoint_privateDnsZoneRemove
=== PAUSE TestAccPrivateEndpoint_privateDnsZoneRemove
=== RUN   TestAccPrivateEndpoint_privateConnectionAlias
=== PAUSE TestAccPrivateEndpoint_privateConnectionAlias
=== RUN   TestAccPrivateEndpoint_updateToPrivateConnectionAlias
=== PAUSE TestAccPrivateEndpoint_updateToPrivateConnectionAlias
=== RUN   TestAccPrivateEndpoint_multipleInstances
=== PAUSE TestAccPrivateEndpoint_multipleInstances
=== RUN   TestAccPrivateEndpoint_multipleIpConfigurations
=== PAUSE TestAccPrivateEndpoint_multipleIpConfigurations
=== CONT  TestAccPrivateEndpointApplicationSecurityGroupAssociationResource_basic
=== CONT  TestAccPrivateEndpoint_privateDnsZoneGroup
=== CONT  TestAccPrivateEndpoint_privateConnectionAlias
=== CONT  TestAccPrivateEndpoint_statiIpAddress
=== CONT  TestAccPrivateEndpoint_basic
=== CONT  TestAccPrivateEndpoint_privateDnsZoneRemove
=== CONT  TestAccPrivateEndpoint_privateDnsZoneUpdate
=== CONT  TestAccPrivateEndpoint_requestMessage
--- PASS: TestAccPrivateEndpoint_requestMessage (193.96s)
=== CONT  TestAccPrivateEndpoint_multipleInstances
--- PASS: TestAccPrivateEndpointApplicationSecurityGroupAssociationResource_basic (200.63s)
=== CONT  TestAccPrivateEndpoint_multipleIpConfigurations
--- PASS: TestAccPrivateEndpoint_statiIpAddress (225.51s)
=== CONT  TestAccPrivateEndpoint_updateToPrivateConnectionAlias
--- PASS: TestAccPrivateEndpoint_basic (250.09s)
=== CONT  TestAccPrivateEndpointApplicationSecurityGroupAssociationResource_deleted
--- PASS: TestAccPrivateEndpoint_privateConnectionAlias (254.07s)
=== CONT  TestAccDataSourcePrivateEndpointConnection_complete
--- PASS: TestAccPrivateEndpoint_privateDnsZoneGroup (316.61s)
=== CONT  TestAccPrivateEndpoint_updateNicName
--- PASS: TestAccPrivateEndpoint_privateDnsZoneRemove (432.17s)
=== CONT  TestAccPrivateEndpoint_updateTag
--- PASS: TestAccDataSourcePrivateEndpointConnection_complete (184.93s)
=== CONT  TestAccPrivateEndpointApplicationSecurityGroupAssociationResource_requiresImport
--- PASS: TestAccPrivateEndpointApplicationSecurityGroupAssociationResource_deleted (281.48s)
=== CONT  TestAccPrivateEndpoint_privateDnsZoneRename
--- PASS: TestAccPrivateEndpoint_privateDnsZoneUpdate (553.56s)
=== CONT  TestAccPrivateEndpointApplicationSecurityGroupAssociationResource_updatePrivateEndpoint
--- PASS: TestAccPrivateEndpoint_multipleIpConfigurations (368.32s)
--- PASS: TestAccPrivateEndpoint_updateToPrivateConnectionAlias (355.73s)
--- PASS: TestAccPrivateEndpoint_multipleInstances (408.95s)
--- PASS: TestAccPrivateEndpoint_updateTag (258.91s)
--- PASS: TestAccPrivateEndpointApplicationSecurityGroupAssociationResource_requiresImport (252.10s)
--- PASS: TestAccPrivateEndpoint_updateNicName (390.63s)
--- PASS: TestAccPrivateEndpointApplicationSecurityGroupAssociationResource_updatePrivateEndpoint (290.58s)
--- PASS: TestAccPrivateEndpoint_privateDnsZoneRename (351.74s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/network      883.344s

and

$ make acctests SERVICE=network TESTARGS='-run="^(TestAccDataSourcePrivateLinkServiceEndpointConnections|TestAccPrivateLinkService|TestAccDataSourcePrivateLinkService)"'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/network -run="^(TestAccDataSourcePrivateLinkServiceEndpointConnections|TestAccPrivateLinkService|TestAccDataSourcePrivateLinkService)" -timeout 180m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccDataSourcePrivateLinkService_complete
=== PAUSE TestAccDataSourcePrivateLinkService_complete
=== RUN   TestAccDataSourcePrivateLinkServiceEndpointConnections_complete
=== PAUSE TestAccDataSourcePrivateLinkServiceEndpointConnections_complete
=== RUN   TestAccPrivateLinkService_basic
=== PAUSE TestAccPrivateLinkService_basic
=== RUN   TestAccPrivateLinkService_requiresImport
=== PAUSE TestAccPrivateLinkService_requiresImport
=== RUN   TestAccPrivateLinkService_update
=== PAUSE TestAccPrivateLinkService_update
=== RUN   TestAccPrivateLinkService_move
=== PAUSE TestAccPrivateLinkService_move
=== RUN   TestAccPrivateLinkService_enableProxyProtocol
=== PAUSE TestAccPrivateLinkService_enableProxyProtocol
=== RUN   TestAccPrivateLinkService_complete
=== PAUSE TestAccPrivateLinkService_complete
=== RUN   TestAccPrivateLinkService_withAlias
=== PAUSE TestAccPrivateLinkService_withAlias
=== CONT  TestAccDataSourcePrivateLinkService_complete
=== CONT  TestAccPrivateLinkService_move
=== CONT  TestAccPrivateLinkService_requiresImport
=== CONT  TestAccPrivateLinkService_basic
=== CONT  TestAccPrivateLinkService_complete
=== CONT  TestAccPrivateLinkService_enableProxyProtocol
=== CONT  TestAccPrivateLinkService_withAlias
=== CONT  TestAccDataSourcePrivateLinkServiceEndpointConnections_complete
--- PASS: TestAccPrivateLinkService_basic (118.27s)
=== CONT  TestAccPrivateLinkService_update
--- PASS: TestAccPrivateLinkService_requiresImport (119.27s)
--- PASS: TestAccPrivateLinkService_complete (126.41s)
--- PASS: TestAccDataSourcePrivateLinkService_complete (136.07s)
--- PASS: TestAccDataSourcePrivateLinkServiceEndpointConnections_complete (182.51s)
--- PASS: TestAccPrivateLinkService_withAlias (193.27s)
--- PASS: TestAccPrivateLinkService_enableProxyProtocol (237.17s)
--- PASS: TestAccPrivateLinkService_move (284.80s)
--- PASS: TestAccPrivateLinkService_update (222.62s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/network       340.920s

[bPhysicist]

I added my signature in the subsequent force push.

[tombuildsstuff]

LGTM - thanks for this @bPhysicist

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.