Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/storage_queue: fixing a bug where the Table URI was obtained rather than the Queue URI #25262

Merged
merged 1 commit into from
Mar 15, 2024
Merged

r/storage_queue: fixing a bug where the Table URI was obtained rather than the Queue URI #25262

merged 1 commit into from
Mar 15, 2024

Conversation

tombuildsstuff
Copy link
Contributor

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave "+1" or "me too" comments, they generate extra noise for PR followers and do not help prioritize for review

Description

Fixes #25261

@tombuildsstuff tombuildsstuff requested a review from a team March 15, 2024 08:18
@tombuildsstuff tombuildsstuff added this to the v3.97.0 milestone Mar 15, 2024
@tombuildsstuff tombuildsstuff mentioned this pull request Mar 15, 2024
Closed
1 task
stephybun
stephybun approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tombuildsstuff LGTM 👍

@tombuildsstuff
Copy link
Contributor Author

Tests pass:

Screenshot 2024-03-15 at 09 34 29

@tombuildsstuff tombuildsstuff merged commit 96deb64 into main Mar 15, 2024
30 checks passed
@tombuildsstuff tombuildsstuff deleted the b/storage-queue-bug branch March 15, 2024 08:35
tombuildsstuff added a commit that referenced this pull request Mar 15, 2024
@tombuildsstuff
updating to include #25262
871677e
@raguldevops
Copy link

Thanks @tombuildsstuff for fixing the issue

@tombuildsstuff tombuildsstuff mentioned this pull request Mar 18, 2024
Closed
1 task
@rcskosir rcskosir mentioned this pull request Mar 18, 2024
Closed
1 task
@tombuildsstuff tombuildsstuff mentioned this pull request Mar 20, 2024
Closed
1 task
@rcskosir rcskosir mentioned this pull request Mar 22, 2024
Closed
1 task
@Mohamednourr
Copy link

I am hitting the same issue with a different error and it was fixed by pining the azurerm provider to v3.95.0

│ Error: expected the subdomain type to be "dfs" but got "blob"

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@raguldevops raguldevops raguldevops approved these changes

@stephybun stephybun stephybun approved these changes

Assignees
No one assigned
Labels
bug service/storage size/XS
Projects
None yet
Milestone
v3.97.0
Development

Successfully merging this pull request may close these issues.

Inconsistency in creating storage account and creating the subdomain as queue
4 participants
@tombuildsstuff @raguldevops @Mohamednourr @stephybun