Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

appconfiguration: support for Environments other than Azure Public #25271

Merged
merged 3 commits into from
Mar 18, 2024
Merged

appconfiguration: support for Environments other than Azure Public #25271

merged 3 commits into from
Mar 18, 2024

Conversation

tombuildsstuff
Copy link
Contributor

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave "+1" or "me too" comments, they generate extra noise for PR followers and do not help prioritize for review

Description

This PR reintroduces support for Environments other than Azure Public to the AppConfiguration resources - and incorporates the commits from but supersedes #24006 by @TZdybel.

Fixes #21550

@tombuildsstuff tombuildsstuff added this to the v3.97.0 milestone Mar 15, 2024
@tombuildsstuff tombuildsstuff requested a review from a team March 15, 2024 17:54
@tombuildsstuff tombuildsstuff mentioned this pull request Mar 15, 2024
Closed
@tombuildsstuff tombuildsstuff force-pushed the b/appconfiguration-for-non-public-clouds branch from 386b3bd to 9f54d2c Compare March 15, 2024 18:15
@tombuildsstuff
appconfiguration: updating to validate the DomainSuffix from the …
5ade42b 
…Environment rather than assuming `*.azconfig.*`

This commit also adds tests covering the state migrations
@tombuildsstuff tombuildsstuff force-pushed the b/appconfiguration-for-non-public-clouds branch from 9f54d2c to 5ade42b Compare March 15, 2024 18:17
manicminer
manicminer approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff merged commit 8298da7 into main Mar 18, 2024
30 checks passed
@tombuildsstuff tombuildsstuff deleted the b/appconfiguration-for-non-public-clouds branch March 18, 2024 08:51
@tombuildsstuff
Copy link
Contributor Author

(Tests look good)

tombuildsstuff added a commit that referenced this pull request Mar 18, 2024
@tombuildsstuff
updating to include #25271
cbc78f7
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@manicminer manicminer manicminer approved these changes

Assignees
No one assigned
Labels
enhancement service/app-configuration size/L state-migration
Projects
None yet
Milestone
v3.97.0
Development

Successfully merging this pull request may close these issues.

Support AppConfiguration in AzureChina/AzureGovernment
2 participants
@tombuildsstuff @manicminer