Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_data_protection_backup_instance_kubernetes_cluster - fix protection error ScenarioPluginInvalidWorkflowDataRequest and UserErrorKubernetesBackupExtensionUnhealthy #25345

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

sinbai
Copy link
Contributor

@sinbai sinbai commented Mar 21, 2024

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave "+1" or "me too" comments, they generate extra noise for PR followers and do not help prioritize for review

Description

  • Set DataSourceSetInfo information to fix protection error ScenarioPluginInvalidWorkflowDataRequest that exists even if the resource is created successfully.

  • Add role assignment in test case and documentation to fix protection error UserErrorKubernetesBackupExtensionUnhealthy
    that exists even though the resource is created successfully.

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevent documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

PASS: TestAccDataProtectionBackupInstanceKubernatesCluster_complete (1391.95s)
PASS: TestAccDataProtectionBackupInstanceKubernatesCluster_basic (1693.22s)
PASS: TestAccDataProtectionBackupInstanceKubernatesCluster_requiresImport (2029.78s)

image

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #25294

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🖍️

@katbyte katbyte merged commit e7e6e7d into hashicorp:main Mar 21, 2024
32 checks passed
@github-actions github-actions bot added this to the v3.97.0 milestone Mar 21, 2024
katbyte added a commit that referenced this pull request Mar 21, 2024
@sinbai sinbai deleted the dataprotection/fix_issue_25294 branch March 28, 2024 02:39
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants