-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Resource: Azure Network Profile #2636
Conversation
azurerm_network_profile
azurerm_network_profile
@tombuildsstuff I really hope you can find time to review this. If we can run containers inside vnets,m our security would be much improved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for the PR @metacpp, i've left some mostly minor comments inline. the major issue i see is the continuing instead of nested if blocks, i think it has the potential to miss elements and shouldn't be done. WDYT?
@katbyte Thanks for the time to reviewing the PR, I've addressed most of the comments in the PR. |
06235af
to
63bd360
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @metacpp
Thanks for pushing those changes; I've left some more comments inline; so that we can get this merged I'm going to push a commit to fix those, I hope you don't mind.
Thanks!
63bd360
to
7bbfb8f
Compare
dismissing since changes have been pushed
This has been released in version 1.28.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.28.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
This PR added the new resource:
azurerm_network_profile
, which is the dependent resource to supportvirtual network
for Azure Container Group requested in #2314.