Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_public_ip - Support setting domain label scope #27730

Closed
1 task done
audunsolemdal opened this issue Oct 23, 2024 · 2 comments · Fixed by #27748
Closed
1 task done

azurerm_public_ip - Support setting domain label scope #27730

audunsolemdal opened this issue Oct 23, 2024 · 2 comments · Fixed by #27748

Comments

@audunsolemdal
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment and review the contribution guide to help.

Description

Would like a new optional paramteer which can set the "domain name label scope" on public IP address resources to avoid risk related to dangling DNS names.

Supported values are

"NoReuse"
"ResourceGroupReuse"
"SubscriptionReuse"
"TenantReuse"

This must be set upon creation of the resource

The API has supported setting this since provider version "Microsoft.Network/publicIPAddresses@2022-11-01", the feature is currently in public preview.

New or Affected Resource(s)/Data Source(s)

azurerm_public_ip

Potential Terraform Configuration

resource "azurerm_public_ip" "example" {
  name                = "acceptanceTestPublicIp1"
  resource_group_name = azurerm_resource_group.example.name
  location            = azurerm_resource_group.example.location
  allocation_method   = "Static"
  domain_label_scope = "TenantReuse" # The domain name label scope can only be specified at the creation of a public IP address
}

References

https://learn.microsoft.com/en-us/azure/virtual-network/ip-services/public-ip-addresses?branch=pr-en-us-268827#domain-name-label-scope-preview
https://learn.microsoft.com/en-us/azure/templates/microsoft.network/publicipaddresses?pivots=deployment-language-terraform

@sinbai
Copy link
Contributor

sinbai commented Oct 24, 2024

Hi @audunsolemdal thanks for opening this issue. PR has been submitted to support domain_label_name_scope. Could you please track it for more updates?

@github-actions github-actions bot added this to the v4.9.0 milestone Nov 5, 2024
Copy link

github-actions bot commented Dec 6, 2024

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants