Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_linux_function_app_slot doesn't allow for TLS 1.3 #28008

Closed
1 task done
dvasdekis opened this issue Nov 14, 2024 · 1 comment · Fixed by #28016
Closed
1 task done

azurerm_linux_function_app_slot doesn't allow for TLS 1.3 #28008

dvasdekis opened this issue Nov 14, 2024 · 1 comment · Fixed by #28016

Comments

@dvasdekis
Copy link

dvasdekis commented Nov 14, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment and review the contribution guide to help.

Terraform Version

1.9.8

AzureRM Provider Version

4.9.0

Affected Resource(s)/Data Source(s)

azurerm_linux_function_app_slot

Terraform Configuration Files

resource "azurerm_linux_function_app_slot" "linuxfuncapp-staging-c" {
  name                          = "staging"
  function_app_id               = azurerm_linux_function_app.linuxfuncapp-c[0].id
  storage_account_name          = azurerm_linux_function_app.linuxfuncapp-c[0].storage_account_name
  storage_account_access_key    = azurerm_storage_account.func_lake.primary_access_key
  builtin_logging_enabled       = true
  public_network_access_enabled = true
  https_only                    = true
  identity { type = "SystemAssigned" }
  site_config {
    always_on                              = false
    http2_enabled                          = true
    minimum_tls_version                    = "1.3"
  }
}

Debug Output/Panic Output

Error: expected site_config.0.minimum_tls_version to be one of ["1.0" "1.1" "1.2"], got 1.3
│
│   with module.sciops-jiraticketaudit-linuxfuncapp.azurerm_linux_function_app_slot.linuxfuncapp-staging-c[0],
│   on ..\..\patterns\components\function_app\resources.tf line 739, in resource "azurerm_linux_function_app_slot" "linuxfuncapp-staging-c":
│  739:     minimum_tls_version                    = "1.3"

Expected Behaviour

Successful apply

Actual Behaviour

azurerm_linux_function_app_slot should apply TLS version 1.3, same as azurerm_linux_function_app. I am able to manually set the TLS to version 1.3 in the staging slot via clickops:
image

Steps to Reproduce

terraform apply

Important Factoids

No

References

No response

@ziyeqf
Copy link
Contributor

ziyeqf commented Nov 14, 2024

Hi @dvasdekis, thanks for reporting.

I just submitted a PR (#28016) for this issue, it's still draft as the tests are in progress. You can subscribe it to keep track, once it merged and released this should be supported.

For any further questions please leave comments.
Thanks.

@github-actions github-actions bot added this to the v4.14.0 milestone Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment