Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add availability set data source #2850

Merged
merged 7 commits into from
Feb 14, 2019
Merged

add availability set data source #2850

merged 7 commits into from
Feb 14, 2019

Conversation

MattMencel
Copy link
Contributor

@MattMencel MattMencel commented Feb 7, 2019

Fixes #2800

First attempt to try to help tackle some of the stuff labeled "good first issue".

@ghost ghost added the size/M label Feb 7, 2019
corrections

function rename and provider
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @MattMencel

Thanks for this PR :)

Taking a look through this looks pretty good to me - if we can add address the comments this should otherwise looks good to me 👍

Thanks!

azurerm/data_source_availability_set.go Outdated Show resolved Hide resolved
azurerm/data_source_availability_set.go Outdated Show resolved Hide resolved
azurerm/data_source_availability_set.go Show resolved Hide resolved
website/docs/d/availability_set.html.markdown Show resolved Hide resolved
@MattMencel
Copy link
Contributor Author

I'm still putting the pieces together.... so I couldn't figure out originally why the d.Set("managed"... was giving me a linting error so I left it out.

Now I see how that ties back to the Azure SDK from the resource and how that relates to the Sku and becomes Aligned.

Thanks!

@ghost ghost removed the waiting-response label Feb 8, 2019
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @MattMencel

Thanks for pushing those changes - besides a couple of minor comments (which I'm going to push a commit to fix - I hope you don't mind) this otherwise LGTM 👍

Thanks!

website/docs/d/availability_set.html.markdown Outdated Show resolved Hide resolved
website/docs/d/availability_set.html.markdown Show resolved Hide resolved
$ acctests azurerm TestAccDataSourceAvailabilitySet_basic
=== RUN   TestAccDataSourceAvailabilitySet_basic
=== PAUSE TestAccDataSourceAvailabilitySet_basic
=== CONT  TestAccDataSourceAvailabilitySet_basic
--- PASS: TestAccDataSourceAvailabilitySet_basic (109.16s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	111.046s
@tombuildsstuff tombuildsstuff merged commit bd365eb into hashicorp:master Feb 14, 2019
tombuildsstuff added a commit that referenced this pull request Feb 14, 2019
@ghost
Copy link

ghost commented Mar 8, 2019

This has been released in version 1.23.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.23.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 17, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants