switch terraform SDK to v0.12-early9

[katbyte]

outstanding issues:

• panic: interface conversion: interface {} is nil, not map[string]interface {}
  • TestAccAzureRMVirtualMachineScaleSet_linuxUpdated, TestAccAzureRMVirtualMachineScaleSet_basicWindows_managedDisk_resize, TestAccAzureRMVirtualMachineScaleSet_upgradeModeUpdate and more
  • phantom nil object, maybe related to this sdk issue, vendor in master to check still broken with master
• TestAccAzureRMTemplateDeployment_withOutputs : Check failed: Check 4/6 error: Output 'tfFalseOutput': expected "0", got &terraform.OutputState{Sensitive:false, Type:"string", Value:"false", mu:sync.Mutex{state:0, sema:0x0}}
• Expected a non-empty plan, but got an empty plan!
  • most lb tests: TestAccAzureRMLoadBalancerBackEndAddressPool_reapply, TestAccAzureRMLoadBalancerRule_reapply
• TestAccAzureRMKubernetesCluster_addAgent: interface {} is nil, not map[string]interface {}
  • phantom nil object, maybe related to this sdk issue, vendor in master to check still broken with master
• cosmos db: Error: Error expanding CosmosDB Account "acctest-190304225533879983" (Resource Group "acctestRG-190304225533879983") geo locations: Eachgeo_location needs to have a unique failover_prioroty. Multiple instances of '0' found

Fixes #3101

[katbyte]

extra nil element:

=== RUN   TestAccAzureRMKubernetesCluster_addAgent
=== PAUSE TestAccAzureRMKubernetesCluster_addAgent
=== CONT  TestAccAzureRMKubernetesCluster_addAgent
panic: interface conversion: interface {} is nil, not map[string]interface {}

goroutine 622 [running]:
github.com/terraform-providers/terraform-provider-azurerm/azurerm.expandKubernetesClusterAddonProfiles(0xc000a4f5e0, 0xc00181c300)
	/Users/kt/hashi/go/src/github.com/terraform-providers/terraform-provider-azurerm/azurerm/resource_arm_kubernetes_cluster.go:752 +0x93f

config
code

[katbyte]

another instance:

=== RUN   TestAccAzureRMVirtualMachineScaleSet_linuxUpdated
=== PAUSE TestAccAzureRMVirtualMachineScaleSet_linuxUpdated
=== CONT  TestAccAzureRMVirtualMachineScaleSet_linuxUpdated
panic: interface conversion: interface {} is nil, not map[string]interface {}

goroutine 847 [running]:
github.com/terraform-providers/terraform-provider-azurerm/azurerm.expandAzureRmVirtualMachineScaleSetNetworkProfile(0xc0018744d0, 0x0)
	/Users/kt/hashi/go/src/github.com/terraform-providers/terraform-provider-azurerm/azurerm/resource_arm_virtual_machine_scale_set.go:1630 +0x1f94

config
code

[kim0]

Hi @katbyte .. Thanks for the tons of fixes here to support 0.12!!

I'm starting on a new TF project soon, and it really pains me to start with 0.11 syntax. Is it possible to get a binary that's compatible with beta-2 sometime soon. Thanks!

[bentterp]

Last week's dev snapshot in http://terraform-0.12.0-dev-snapshots.s3-website-us-west-2.amazonaws.com/terraform-provider-azurerm/1.25.0-dev20190415H16-dev/ gives me

Incompatible API version with plugin. Plugin version: 4, Client versions: [5] which I don't think is the expected outcome

[bentterp]

@kim0 while we wait for this to be resolved, something like this might help you: https://gist.github.com/bentterp/d9e8dcc9d17bfcce87a7563a769e9070

.... spoke too soon: now the build is broken:

...
vendor/github.com/Azure/azure-sdk-for-go/services/web/mgmt/2018-02-01/web/models.go:2155:20: future.Done undefined (type *AppsCreateOrUpdateSlotFuture has no field or method Done)
vendor/github.com/Azure/azure-sdk-for-go/services/web/mgmt/2018-02-01/web/models.go:2184:20: future.Done undefined (type *AppsCreateOrUpdateSourceControlFuture has no field or method Done)
vendor/github.com/Azure/azure-sdk-for-go/services/web/mgmt/2018-02-01/web/models.go:2213:20: future.Done undefined (type *AppsCreateOrUpdateSourceControlSlotFuture has no field or method Done)
vendor/github.com/Azure/azure-sdk-for-go/services/web/mgmt/2018-02-01/web/models.go:2213:20: too many errors

😰

[katbyte]

@kim0 & @bentterp,

Sorry for the delay in getting a .12 compatible binary out, there was a regression with proxies we wanted to resolve and release a fix for first. However that just went out this morning in v1.26.0 so check back soon for v1.27.0 with .12 support 😉

[mbfrahry]

LGTM!

[bentterp]

@kim0 While we wait for 1.27.0, the beta1 snapshot of 1.23.0 seems to work with beta2 as well - http://terraform-0.12.0-dev-snapshots.s3-website-us-west-2.amazonaws.com/terraform-provider-azurerm/1.23.0-dev20190216H00-dev/

[katbyte]

@bentterp & @kim0,

just released v1.27 with .12 support 🙂

[bentterp]

@katbyte

just released v1.27 with .12 support 🙂

You spoil me 🤗

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!