azurerm_automation_module does not wait for import to complete.

[Laikulo]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform (and AzureRM Provider) Version

Terraform v0.11.13
+ provider.azurerm v1.23.0

Affected Resource(s)

• azurerm_automation_module

Terraform Configuration Files

main.tf

resource "azurerm_automation_account" "ctfautomation" {
  name                = "CTFAutomation"
  location            = "${var.location}"
  resource_group_name = "${var.resource_group}"

  sku {
    name = "Basic"
  }
}

resource "azurerm_automation_module" "profile" {
  name                    = "AzureRM.Profile"
  resource_group_name     = "${var.resource_group}"
  automation_account_name = "${azurerm_automation_account.ctfautomation.name}"

  module_link {
    uri = "https://psg-prod-eastus.azureedge.net/packages/azurerm.profile.4.6.0.nupkg"
  }
}

resource "azurerm_automation_module" "container_instance" {
  name                    = "AzureRM.ContainerInstance"
  resource_group_name     = "${var.resource_group}"
  automation_account_name = "${azurerm_automation_account.ctfautomation.name}"

  module_link {
    uri = "https://psg-prod-eastus.azureedge.net/packages/azurerm.containerinstance.0.2.12.nupkg"
  }

  depends_on = [
    "azurerm_automation_module.profile",
  ]
}

Azure CLI was used for authentication.

Debug Output

https://gist.github.com/KJ4IPS/98e05ac227b0099ecc2e691d69313dff

Note: powershell put a NativeCommandError in here, feel free to ignore it.

Panic Output

Terraform did not panic

Expected Behavior

Terraform should have waited for the fist module import (profile) to complete before importing the second (container_instance)

Actual Behavior

Terraform started the import of profile, then immedatly started the import of container_instance without waiting for profile to finish.

This lead to the failure of the container_instance import, as container_instance depends (in a powershell sense) on profile. (depends_on was used to ensure correct import order)

Additionally, terraform does not see the failed import as drift, so it will leave the failed import around until it is tainted, or drifts in some other aspect.

Steps to Reproduce

1. terraform apply

References

• handle dependencies between automation modules #2600 is semi-related, as it deals with module dependencies.

[ahmddp]

I've faced exactly the same problem.

My workaround was adding a 120-second delay between two azurerm_automation_modules.

resource "azurerm_automation_module" "AzureRMProfile" {
  name                    = "AzureRM.Profile"
  resource_group_name     = "${var.resource_group}"
  automation_account_name = "${azurerm_automation_account.myautomation.name}"

  module_link = {
    uri = "https://devopsgallerystorage.blob.core.windows.net/packages/azurerm.profile.5.8.3.nupkg"
  }
}

resource "null_resource" "delay" {
  provisioner "local-exec" {
    command = "sleep 120"
  }
  triggers = {
    "before" = "${azurerm_automation_module.AzureRMProfile.id}"
  }
}

resource "azurerm_automation_module" "AzureRMCompute" {
  name                    = "AzureRM.Compute"
  resource_group_name     = "${var.resource_group}"
  automation_account_name = "${azurerm_automation_account.myautomation.name}"

  module_link = {
    uri = "https://devopsgallerystorage.blob.core.windows.net/packages/azurerm.compute.5.9.1.nupkg"
  }

  depends_on = [
    "null_resource.delay"
  ]
}

[tombuildsstuff]

hey @KJ4IPS @ahmddp

Thanks for opening this issue :)

Taking a quick look into this this appears to be a duplicate of #2600 - since that also includes some additional context around the ModuleProvisioningState field, I'm going to close this issue in favour of that one - would you mind subscribing to that one for updates?

Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!