-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add resource_file to batch pool start_task #3192
Add resource_file to batch pool start_task #3192
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @stuartleeks
Thanks for this PR :)
Taking a look through this mostly LGTM - if we can fix up the minor comments this should otherwise be good to merge 👍
Thanks!
Thanks @tombuildsstuff - the changes you requested are in the latest pushed commit :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @stuartleeks,
Thanks for the revisions! This is looking pretty good to me now outside the comments i've left inline.
You can use the tool here https://github.com/katbyte/terrafmt to easily format the test file.
Co-Authored-By: stuartleeks <stuart@leeks.net>
ea847c3
to
5c11226
Compare
d081e7e
to
811a2de
Compare
@katbyte / @tombuildsstuff - I've rebased the changes in this PR now that #3097 is merged, and think I've addressed the PR comments that you left previously. Let me know if there are any other changes you'd like to see before this is merged :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @stuartleeks
Thanks for pushing those changes - taking a look through aside from a couple of minor docs changes (which I'm going to push a commit for, I hope you don't mind!) this otherwise LGTM 👍
Thanks!
dismissing since changes have been pushed
@tombuildsstuff - thanks for updating the docs :-) |
Aside from the long running case sensitivity of the resource group name (which I'll address in a separate PR) - the tests pass/LGTM 👍 Thanks again @stuartleeks |
This has been released in version 1.25.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.25.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Closes #2823
Add
resource_file
tostart_task
property indata_source_batch_pool
andresource_batch_pool
Add tests
Add docs