Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[azurerm_kubernetes_cluster] - Add Option for Node Resource Group Name #3354

Closed
slynickel opened this issue May 1, 2019 · 1 comment · Fixed by #3785
Closed

[azurerm_kubernetes_cluster] - Add Option for Node Resource Group Name #3354

slynickel opened this issue May 1, 2019 · 1 comment · Fixed by #3785

Comments

@slynickel
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

With the 2019-04-15 release of AKS support for custom resource group names was added.

  • New Features
    • Customers may now provide custom Resource Group names.
      • This means that users are no longer locked into the MC_* resource name group. On cluster creation you may pass in a custom RG and AKS will inherit that RG, permissions and attach AKS resources to the customer provided resource group.
      • Currently, you must pass in a new RG (resource group) must be new, and can not be a pre-existing RG. We are working on support for pre-existing RGs.
      • This change requires newly provisioned clusters, existing clusters can not be migrated to support this new capability. Cluster migration across subscriptions and RGs is not currently supported.

This feature request is to have the custom resource group name field added to the terraform provider.

New or Affected Resource(s)

  • azurerm_kubernetes_cluster

Potential Terraform Configuration

I'm not completely clear if go-sdk actually offers this support yet but I wanted to get the issue out there to see if other folks also want this. Right now the 2019-04-30 version of the go-sdk has this node resource group property marked as READ-ONLY. I could be reading this wrong though. The CreateOrUpdate part of the client does reference the 2019-02-01 version of the rest API. That version of the rest API has the node resource as a configuration option.

As for syntax to add to azurerm_kubernetes_cluster, since it's a single response item with no dependencies I wouldn't expect this to need it's own block. Maybe that's better form though.

References

@ghost
Copy link

ghost commented Aug 19, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants