Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_app_service & azurerm_app_service_slot: support for specifying user-assigned identities #3637

Merged
merged 9 commits into from
Jul 7, 2019
Merged

azurerm_app_service & azurerm_app_service_slot: support for specifying user-assigned identities #3637

merged 9 commits into from
Jul 7, 2019

Conversation

joakimhellum
Copy link

@joakimhellum joakimhellum commented Jun 11, 2019

Reference to #3495

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @joakimhellum-in,

Thanks for the PR, overall this looks good with a few comments left inline. Once those are addressed this should be good to merge!

azurerm/resource_arm_app_service.go Outdated Show resolved Hide resolved
azurerm/resource_arm_app_service.go Outdated Show resolved Hide resolved
azurerm/resource_arm_app_service_test.go Outdated Show resolved Hide resolved
azurerm/resource_arm_app_service_test.go Outdated Show resolved Hide resolved
@katbyte katbyte added this to the v1.31.0 milestone Jun 13, 2019
azurerm/resource_arm_app_service.go Outdated Show resolved Hide resolved
@ghost ghost added size/XL and removed size/L labels Jun 13, 2019
@joakimhellum
Copy link
Author

joakimhellum commented Jun 13, 2019

@katbyte Have made an attempt to address code review comments. Sorry about the mess and for making you review this again.
FYI Will create another PR to enable this for Function App as well.

@ghost ghost removed the waiting-response label Jun 13, 2019
@joakimhellum joakimhellum changed the title azurerm_app_service: support for specifying user assigned identities azurerm_app_service & azurerm_app_service_slot: support for specifying user-assigned identities Jun 14, 2019
@katbyte katbyte modified the milestones: v1.31.0, v1.32.0 Jun 28, 2019
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @joakimhellum-in

Thanks for pushing those changes - taking a look through this now LGTM - I'll kick off the tests now 👍

Thanks!

@tombuildsstuff tombuildsstuff dismissed katbyte’s stale review July 7, 2019 09:41

dismissing since changes have been pushed

@tombuildsstuff
Copy link
Contributor

@joakimhellum-in just noticed there's a conflict - I hope you don't mind but I'm going to rebase this so that we can run the tests / get this merged :)

@tombuildsstuff
Copy link
Contributor

Tests pass - thanks for this @joakimhellum-in

Screenshot 2019-07-07 at 12 46 42

@tombuildsstuff tombuildsstuff merged commit af4a52c into hashicorp:master Jul 7, 2019
tombuildsstuff added a commit that referenced this pull request Jul 7, 2019
@ghost
Copy link

ghost commented Jul 30, 2019

This has been released in version 1.32.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.32.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Aug 6, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants