r/databricks_workspace: support for workspace parameters

[notchairmk]

Allows for optional map of workspace parameter key/values (e.g. customPrivateSubnetName, customPublicSubnetName). https://docs.microsoft.com/en-us/rest/api/databricks/workspaces/createorupdate#workspace

The list of accepted parameter keys included in the doc updates was provided in a response through the sdk with a disallowed parameter. Can't find the list in any other documentation though.

Includes test updates.

Fixes #3001

[tombuildsstuff]

hey @notchairmk

Thanks for this PR :)

Taking a look through whilst this approach works, there's several limitations to it (for example, where we're unable to provide validation for the specific fields to confirm that a Resource ID is a Resource ID at plan time) - that I think this may want to take a slightly different approach.

In the azurerm_redis_cache resource the API takes a similar approach (requiring a key-value pair of parameters) but we instead define a Terraform Schema for those fields and then map from the Terraform Schema to the Redis Configuration and map back from the Redis Configuration to the Terraform Schema which means that we can get the best of both worlds.

As such - could we update this PR to take a similar approach?

Thanks!

[tombuildsstuff]

Just to add an update here: I've opened a PR on the Swagger repository making this a struct rather than a dictionary, so that we can expose this accordingly: Azure/azure-rest-api-specs#6917

[notchairmk]

Okay awesome, that is what I wasn't sure how to get done. Thanks!

[katbyte]

@notchairmk, we just merged v38 of the sdk today, so this should be unblocked!

[katbyte]

Thanks for updating the PR @notchairmk, just one comment left about nil checks that once addressed this should be good to merge

[notchairmk]

thanks @katbyte, updated, all suggestions should now be addressed

[katbyte]

Hi @notchairmk,

This looks great now, however could you merge in master so we can ensure all the travis CI checks pass? thanks!

[notchairmk]

Alright, rebased off of master and fixed spacing for tflint.

[katbyte]

Thanks @notchairmk! LGTM now 👍

[ghost]

This has been released in version 1.42.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.42.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!