Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_storage_share not supporting quotas above 5TB, regardless of storage account type #4034

Closed
philbal611 opened this issue Aug 7, 2019 · 2 comments · Fixed by #4054
Closed

Comments

@philbal611
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform (and AzureRM Provider) Version

Terraform -- 0.11.13
AzureRM -- 1.32.1

Affected Resource(s)

  • azurerm_storage_share

Terraform Configuration Files

resource "azurerm_storage_account" "test" {
  name                     = "azureteststorage"
  resource_group_name      = "${azurerm_resource_group.test.name}"
  location                 = "${azurerm_resource_group.test.location}"
  account_tier             = "Premium"
  account_replication_type = "LRS"
}

resource "azurerm_storage_share" "testshare" {
  name                 = "sharename"
  storage_account_name = "${azurerm_storage_account.test.name}"
  quota                = 6144
}

Debug Output

Panic Output

Expected Behavior

Per MS documentation, Storage Shares that belong to Premium storage accounts are allowed quotas up to 100TB, and recently, Standard storage accounts are also allowing quotas up to 100TB (preview). Terraform should not be catching this 5TB limitation before the plan phase.

Actual Behavior

Terraform returns an error before returning a plan:

azurerm_storage_share.testshare: expected quota to be in the range (1 - 5120), got 6144

Steps to Reproduce

  1. Configure code above
  2. Run terraform plan

Important Factoids

References

@nexxai
Copy link
Contributor

nexxai commented Aug 10, 2019

Submitted a PR for this: #4054. It's my first time doing something in Go so I hope I didn't mess things up too badly.

@ghost
Copy link

ghost commented Sep 10, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants