azurerm_template_deployment - support for specifying parameters via parameters_body

[civascu]

Currently, the resource azurerm_template_deployment only supports passing in parameters as a key, value pair. This does not allow the use of parameters that reference a KeyVault that is enabled for template deployment, which is desired in some use-cases.

One such use-case is executing a bootstrap script when a virtual machine (or scale set) comes online - via the Azure extension mechanism - and inject secrets into the script being executed, without the operator that runs terraform to know their value upfront.

This is enabled similar to the template_body parameter, and it passes the JSON string to the Azure Rest API.

[civascu]

One similar issue I ran into was here: hashicorp/terraform#8331

[paultyng]

Can you set this as mutually exclusive with parameters (see ConflictsWith) and validate that it is valid JSON?

[paultyng]

You may also want a StateFunc to normalize the JSON so that things like whitespace don't cause diffs.

[tombuildsstuff]

pushed a commit to add these

[paultyng]

Looks like there is a merge conflict as well, so you should probably rebase.

[tombuildsstuff]

hey @civascu

Apologies for the delayed movement on this PR - I'm going to rebase this and push a commit to fix the issues that @paultyng identified (I hope you don't mind!); then we should be good to run the tests with this.

Thanks!

[tombuildsstuff]

Tests pass:

$ acctests azurerm TestAccAzureRMTemplateDeployment_
=== RUN   TestAccAzureRMTemplateDeployment_basic
--- PASS: TestAccAzureRMTemplateDeployment_basic (218.88s)
=== RUN   TestAccAzureRMTemplateDeployment_disappears
--- PASS: TestAccAzureRMTemplateDeployment_disappears (210.92s)
=== RUN   TestAccAzureRMTemplateDeployment_withParams
--- PASS: TestAccAzureRMTemplateDeployment_withParams (230.95s)
=== RUN   TestAccAzureRMTemplateDeployment_withOutputs
--- PASS: TestAccAzureRMTemplateDeployment_withOutputs (221.63s)
=== RUN   TestAccAzureRMTemplateDeployment_withError
--- PASS: TestAccAzureRMTemplateDeployment_withError (354.04s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	1236.456s

pushed updates to resolve these issues

[tombuildsstuff]

hey @civascu

Apologies again for the delayed review time here - as I mentioned I've pushed a couple of commits to rebase this & fix the issues that @paultyng identified; and this now LGTM 👍

Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!