Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new data source azurerm_network_ddos_protection_plan #4228

Merged
merged 11 commits into from
Sep 5, 2019

Conversation

tracypholmes
Copy link
Contributor

@tracypholmes tracypholmes commented Sep 3, 2019

Fixes #3851.

Output from acceptance testing

TF_ACC=1 go test ./azurerm -v -parallel 11 -test.run=TestAccAzureRMNetworkDDoSProtectionPlan -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMNetworkDDoSProtectionPlan
=== RUN   TestAccAzureRMNetworkDDoSProtectionPlan/normal
=== RUN   TestAccAzureRMNetworkDDoSProtectionPlan/normal/basic
=== RUN   TestAccAzureRMNetworkDDoSProtectionPlan/datasource
=== RUN   TestAccAzureRMNetworkDDoSProtectionPlan/datasource/basic
--- PASS: TestAccAzureRMNetworkDDoSProtectionPlan (184.15s)
    --- PASS: TestAccAzureRMNetworkDDoSProtectionPlan/normal (88.13s)
        --- PASS: TestAccAzureRMNetworkDDoSProtectionPlan/normal/basic (88.13s)
    --- PASS: TestAccAzureRMNetworkDDoSProtectionPlan/datasource (96.01s)
        --- PASS: TestAccAzureRMNetworkDDoSProtectionPlan/datasource/basic (96.01s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm    184.222s

@tracypholmes tracypholmes requested a review from katbyte September 3, 2019 20:34
@ghost ghost added the size/M label Sep 3, 2019
@tracypholmes tracypholmes changed the title Added new data source azurerm_network_ddos_protection_plan [WIP] Added new data source azurerm_network_ddos_protection_plan Sep 4, 2019
@ghost ghost added size/L documentation and removed size/M labels Sep 4, 2019
@tracypholmes tracypholmes changed the title [WIP] Added new data source azurerm_network_ddos_protection_plan Added new data source azurerm_network_ddos_protection_plan Sep 4, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @tracypholmes ! Overall this looks good. Once the few minor comments i've left inline are addressed this should be good to merge!

azurerm/data_source_network_ddos_protection_plan.go Outdated Show resolved Hide resolved
azurerm/data_source_network_ddos_protection_plan.go Outdated Show resolved Hide resolved
azurerm/data_source_network_ddos_protection_plan_test.go Outdated Show resolved Hide resolved
website/docs/d/network_ddos_protection_plan.html.markdown Outdated Show resolved Hide resolved
website/docs/d/network_ddos_protection_plan.html.markdown Outdated Show resolved Hide resolved
website/docs/d/network_ddos_protection_plan.html.markdown Outdated Show resolved Hide resolved
website/docs/d/network_ddos_protection_plan.html.markdown Outdated Show resolved Hide resolved
@tracypholmes tracypholmes merged commit 4496a90 into master Sep 5, 2019
@tracypholmes tracypholmes deleted the f-data_source_ddos-new branch September 5, 2019 01:14
tracypholmes added a commit that referenced this pull request Sep 5, 2019
@ghost
Copy link

ghost commented Sep 18, 2019

This has been released in version 1.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.34.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: data source for azurerm_network_ddos_protection_plan
3 participants