Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cognitive Services: support for Luis.Authoring #4319

Closed
tommyJimmy87 opened this issue Sep 13, 2019 · 10 comments
Closed

Cognitive Services: support for Luis.Authoring #4319

tommyJimmy87 opened this issue Sep 13, 2019 · 10 comments

Comments

@tommyJimmy87
Copy link

Would be cool to have the possibility to add the new Luis Authoring Cognitive Service and also the Web App Bot as possible resources.

@tombuildsstuff tombuildsstuff added this to the v1.34.0 milestone Sep 13, 2019
@tombuildsstuff
Copy link
Contributor

hi @tommyJimmy87

Thanks for opening this issue :)

Taking a look into this I believe that LUIS support is available via the kind field within the azurerm_cognitive_account resource - would you be able to take a look and see if that works for you? In addition support for Bots has been merged and will form part of the v1.34.0 release of the Azure Provider. Since this functionality appears to be supported I'm going to close this issue for the moment - however please let us know if that doesn't work for you and we'll take another look.

Thanks!

@tommyJimmy87
Copy link
Author

@tombuildsstuff
Hi thanks for the update about the Bot Service.

Regarding the LUIS Authoring is a different LUIS Cognitive Service where you can choose the Authoring API which will allow to share applications across different accounts in your organization. From the LUIS cognitive service kind in terraform I cannot see the option to choose the Authoring API.

https://docs.microsoft.com/en-us/azure/cognitive-services/luis/luis-concept-keys

Screen Shot 2019-09-13 at 16 56 38

@tombuildsstuff
Copy link
Contributor

@tommyJimmy87 so that we could understand that better, would you be able to show the generated ARM Template for that (you should be able to see it by clicking "Automated/Template Deployment" at the bottom of the create screen)? Thanks!

@tommyJimmy87
Copy link
Author

@tombuildsstuff Sure.

    "$schema": "http://schema.management.azure.com/schemas/2014-04-01-preview/deploymentTemplate.json#",
    "contentVersion": "1.0.0.0",
    "parameters": {
        "name": {
            "type": "string"
        },
        "authoringLocation": {
            "type": "string"
        },
        "authoringSku": {
            "type": "string"
        }
    },
    "resources": [
        {
            "apiVersion": "2016-02-01-preview",
            "name": "[parameters('name')]",
            "location": "[parameters('authoringLocation')]",
            "type": "Microsoft.CognitiveServices/accounts",
            "kind": "LUIS.Authoring",
            "sku": {
                "name": "[parameters('authoringSku')]"
            },
            "properties": {
                "customSubDomainName": "[parameters('name')]"
            }
        }
    ]
}```

@tommyJimmy87
Copy link
Author

@tombuildsstuff
I guess is a bit confusing from the Azure guys because if you see from the marketplace they have the same service replicated but with the first one you can create the LUIS app and with the second you can specify which API to use (Authoring, runtime.... )

Screen Shot 2019-09-13 at 18 21 02

@tombuildsstuff tombuildsstuff changed the title LUIS Authoring & Web App Bot Cognitive Services: support for Luis.Authoring Sep 13, 2019
@tombuildsstuff tombuildsstuff removed this from the v1.34.0 milestone Sep 13, 2019
@tombuildsstuff
Copy link
Contributor

hey @tommyJimmy87

Thanks for confirming that; it looks like this new option just needs to be added to the azurerm_cognitive_services resources list then - as such I've tagged this as such :)

Thanks!

@enricsoler
Copy link

Hi @tombuildsstuff If it's ok with you, I would like to try to do this, is it ok?

@katbyte
Copy link
Collaborator

katbyte commented Nov 17, 2019

fixed by #4888

@katbyte katbyte closed this as completed Nov 17, 2019
@ghost
Copy link

ghost commented Nov 26, 2019

This has been released in version 1.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.37.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants