Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fields missing from first release of Azure Application Gateway Resource #451

Closed
1 of 2 tasks
isaacsgi opened this issue Oct 24, 2017 · 3 comments
Closed
1 of 2 tasks
Labels
enhancement service/application-gateway upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR

Comments

@isaacsgi
Copy link

isaacsgi commented Oct 24, 2017

  • Firewall Disabled Rule Groups
  • SSL Policies

Resource mapping code is missing some detailed attributes of elements in current Azure REST API:
**webApplicationFirewallConfiguration[i].disabledRuleGroups**
"disabledRuleGroups": {
          "type": "array",
          "items": {
            "$ref": "#/definitions/ApplicationGatewayFirewallDisabledRuleGroup"
          },
          "description": "The disabled rule groups."
        }
    "ApplicationGatewayFirewallDisabledRuleGroup": {
      "properties": {
        "ruleGroupName": {
          "type": "string",
          "description": "The name of the rule group that will be disabled."
        },
        "rules": {
          "type": "array",
          "items": {
            "type": "integer",
            "format": "int32",
            "x-nullable": false
          },
          "description": "The list of rules that will be disabled. If null, all rules of the rule group will be disabled."
        }
      },
      "required": [
        "ruleGroupName"
      ],
      "description": "Allows to disable rules within a rule group or an entire rule group."
    },
**"ApplicationGatewaySslPolicy":** {
      "properties": {
        "disabledSslProtocols": {
          "type": "array",
          "description": "Ssl protocols to be disabled on application gateway.",
          "items":{
            "type": "string",
            "$ref": "#/definitions/ProtocolsEnum",
            "x-ms-enum": {
              "name": "ApplicationGatewaySslProtocol",
              "modelAsString": true
            }
          }
        },
        "policyType": {
          "type": "string",
          "description": "Type of Ssl Policy",
          "enum": [
            "Predefined",
            "Custom"
          ],
          "x-ms-enum": {
            "name": "ApplicationGatewaySslPolicyType",
            "modelAsString": true
          }
        },
        "policyName":{
          "$ref": "#/definitions/PolicyNameEnum",
          "description": "Name of Ssl predefined policy"
        },
        "cipherSuites":{
          "type": "array",
          "items":{
            "$ref": "#/definitions/CipherSuitesEnum"
          },
          "description":"Ssl cipher suites to be enabled in the specified order to application gateway."\
        },
        "minProtocolVersion":{
          "$ref": "#/definitions/ProtocolsEnum",
          "description": "Minimum version of Ssl protocol to be supported on application gateway."
        }
      },
      "description": "Application Gateway Ssl policy."
    }

References

Following from the initial release/first merge with main of the Application Gateway Resource: #413
Also based on this version of the Azure REST API:
https://github.com/Azure/azure-rest-api-specs/blob/current/specification/network/resource-manager/Microsoft.Network/2017-08-01/applicationGateway.json

@tombuildsstuff tombuildsstuff added this to the 1.0.1 milestone Dec 18, 2017
@tombuildsstuff tombuildsstuff self-assigned this Dec 18, 2017
@tombuildsstuff tombuildsstuff modified the milestones: 1.0.1, Future Jan 10, 2018
@tombuildsstuff tombuildsstuff removed their assignment Feb 13, 2018
@katbyte katbyte added the upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR label May 18, 2018
@katbyte
Copy link
Collaborator

katbyte commented May 18, 2018

Blocked on API fixes

@tombuildsstuff
Copy link
Contributor

hi @isaacsgi

Given this issue is blocked on an upstream issue in the Azure API rather than keeping multiple issues open and trying to ensure they all remain up to date - I'm going to close this in favour of #1576 which is the Meta-Issue tracking the Bugs and Enhancements for the Application Gateway Resource. Once the bug in the API is fixed we should be able to take a look into this, but we'll keep track of the status of this issue there for the moment.

Thanks!

@tombuildsstuff tombuildsstuff modified the milestones: Future, Being Sorted Oct 25, 2018
@ghost
Copy link

ghost commented Mar 6, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement service/application-gateway upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR
Projects
None yet
Development

No branches or pull requests

4 participants