Added Terraform Azure Partner ID

[echuvyrov]

Added Terraform Azure Partner GUID

[StefanSchoof]

Why not use only a single Sprintf after the if else (with a local variable), to eliminate the code duplication?

[katbyte]

Suggested change

	client.UserAgent = fmt.Sprintf("%s pid-%s", client.UserAgent, terraformGUID)
	if partnerID == "" {
	partnerID := "222c6c49-1b0a-5959-a213-6608f9eb8820"
	}
	client.UserAgent = fmt.Sprintf("%s pid-%s", client.UserAgent, partnerID)

[katbyte]

Hi @echuvyrov,

Could you please explain the rationale for this PR & change? What does that GUID represent?

[ghost]

This has been released in version 1.36.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.36.0"
}
# ... other configuration ...

[schuettecarsten]

Sorry, this change is absolutely unacceptable.
If no provider_id is specified, then no provider_id should be sent to Azure.

I've created #4747 to remove the default partner_id.
Please read my explanation there and upvote the bug report.

[tesharp]

To ask same as @katbyte
Could you please explain the rationale for this PR & change?
Why has this been added as default?

[OliverCole]

@paultyng I understand you want to lock #4747, but I think there is the unresolved question of why @katbyte’s reasonable query was either ignored or answered out of band?

[echuvyrov]

Apologies for not responding to this right away.

As Mitchell mentioned in his response, @katbyte and I work together on the Terraform provider for Azure (although she does all the heavy lifting). We have weekly syncs where we discuss issues that our joint customers bring to us and pending PRs. We discussed the Partner ID integration during one of the calls and did not loop back around to respond on the PR what had been discussed. That was a major oversight that we will work to avoid in the future.

[OliverCole]

@echuvyrov Thanks for clarifying.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!