Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partner ID: allowing users to opt-out of the default Terraform Partner ID #4751

Merged
merged 1 commit into from
Oct 29, 2019

Conversation

tombuildsstuff
Copy link
Contributor

This PR introduces an opt-out for the Default "Terraform Partner ID" introduced in #4663

Whilst the partner_id field can be used for various purposes - this Default Terraform Partner ID is only used by Microsoft to better understand Terraform's usage (and is only sent when a custom Partner ID isn't specified) - more information can be found in this comment.

This PR allows users to opt out of this Default Partner ID either through the Provider Block, like so:

provider "azurerm" {
  version = "=1.36.1"
  disable_terraform_partner_id = true
}

or by setting the Environment Variable ARM_DISABLE_TERRAFORM_PARTNER_ID to true.

Fixes #4747

@tombuildsstuff tombuildsstuff added this to the v1.36.1 milestone Oct 29, 2019
@tombuildsstuff tombuildsstuff requested a review from a team October 29, 2019 18:49
Copy link
Contributor

@tracypholmes tracypholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once all checks have passed!

@tombuildsstuff tombuildsstuff merged commit 2103182 into master Oct 29, 2019
@tombuildsstuff tombuildsstuff deleted the f/partner-id-opt-out branch October 29, 2019 19:31
@ghost
Copy link

ghost commented Nov 29, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove default "terraform" partner_id
3 participants