Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/kubernetes_cluster: mapping fields out of the response case-insensitively #4929

Merged
merged 1 commit into from
Nov 21, 2019

Conversation

tombuildsstuff
Copy link
Contributor

Turns out the Azure Portal uses a different casing to the API - as such when updating
a Kubernetes Cluster in the Azure Portal provisioned through some other means, that the
casing on the addOnProfiles block will be different

As such this PR updates the flatten function to check for keys using a case-insensitive
comparison; which should match either.

Fixes #2993

…tively

Turns out the Azure Portal uses a different casing to the API - as such when updating
a Kubernetes Cluster in the Azure Portal provisioned through some other means, that the
casing on the addOnProfiles block will be different

As such this PR updates the flatten function to check for keys using a case-insensitive
comparison; which should match either.

Fixes #2993
@tombuildsstuff tombuildsstuff added this to the v1.37.0 milestone Nov 20, 2019
@tombuildsstuff tombuildsstuff requested a review from a team November 20, 2019 12:06
@ghost ghost added the size/XS label Nov 20, 2019
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tombuildsstuff tombuildsstuff merged commit a5eb890 into master Nov 21, 2019
@tombuildsstuff tombuildsstuff deleted the f/aks-manual-updates branch November 21, 2019 07:02
tombuildsstuff added a commit that referenced this pull request Nov 21, 2019
@ghost
Copy link

ghost commented Nov 26, 2019

This has been released in version 1.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.37.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrading Kubernetes cluster via Azure Portal causes terraform to try to recreate it
2 participants