Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Azure VM host and host group #5332

Closed
ssrirama-aka opened this issue Jan 7, 2020 · 8 comments
Closed

Support for Azure VM host and host group #5332

ssrirama-aka opened this issue Jan 7, 2020 · 8 comments

Comments

@ssrirama-aka
Copy link

ssrirama-aka commented Jan 7, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Azure's Dedicated hosts service became generally available early December 2019. My team is evaluating this capability to run payloads on dedicated h/w. Our provisioning scripts are mostly Terraform-based.

There are two new resource constructs enabled for dedicated hosts and a change to how a VM is placed on a dedicated host:
az vm host group create - create a host group
az vm host create - create a host in a given host group
az vm create --host-group --host

Specifying host-group and host with the vm create command places the VM on the particular host.

Are there plans to support these constructs in the Terraform provider? If yes, is there an anticipated time-frame to deliver support?

New or Affected Resource(s)

  • azurerm_virtual_machine
@magodo
Copy link
Collaborator

magodo commented Jan 8, 2020

I have filed an PR #5307

@ssrirama-aka
Copy link
Author

I have filed an PR #5307

@magodo Thanks for the response. Am I correct in assuming the changes will enable these 3 things: create host group, create host in host group and associate new VM with the host?

@magodo
Copy link
Collaborator

magodo commented Jan 9, 2020

@ssrirama-aka Sure, after dedicated host group PR is merged, I will submit another PR to support dedicated host. Afterwards, hopefully I will expose the host property in virtual machine resource(s) to associate with the host.

@tombuildsstuff
Copy link
Contributor

👋

Since we're superseding the azurerm_virtual_machine resource in 2.0 (which I'm working on at the moment - more details can be found in #2807) - rather than adding a field to the existing azurerm_virtual_machine resource (which is now feature-frozen) it'd be better to instead look to add this to the replacement resources (which I'm working on at the moment).

Since I'm working on these new resources at the moment I'll look to include support for this in the new VM resources - which we should be able to do once support for Dedicated Host Group is added via #5307 (which we'll be merging shortly) and Dedicated Hosts are available in the near future 👍

Thanks!

@ssrirama-aka
Copy link
Author

@tombuildsstuff So the new host attribute would be added separately to the proposed azurerm_linux_virtual_machine and azurerm_windows_virtual_machine resources and be available only from 2.0 forward. This makes sense to me, though it means changes to our existing scripts.

@ssrirama-aka
Copy link
Author

@tombuildsstuff You indicated that azurerm_virtual_machine resource is feature frozen. So there's absolutely no chance of introducing the changes necessary for dedicated hosts into this resource in a 1.x release?

The reason I ask is that our project needs to migrate to dedicated hosts as soon as possible. But we want to only go there with a clean, consistent azurerm Terraform provider version that fully supports dedicated hosts. With 2.0 being a significant release with many changes, some breaking, I was wondering if a 1.x version could be a vehicle for the dedicated host changes against azurerm_virtual_machine.

@tombuildsstuff
Copy link
Contributor

👋

Closing this out since support for these is now available in the form of azurerm_dedicated_host and `azurerm_dedicated_host_group

@ghost
Copy link

ghost commented Mar 6, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants