Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new data source azurerm_eventhub_namespace_authorization_rule #5489

Merged
merged 12 commits into from
Jan 29, 2020

Conversation

tracypholmes
Copy link
Contributor

@tracypholmes tracypholmes commented Jan 23, 2020

Fixes #3577.
image

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pr @tracypholmes, i've left some comments inline but overall this is looking good

@tracypholmes tracypholmes requested a review from katbyte January 23, 2020 23:16
@tombuildsstuff tombuildsstuff modified the milestones: v1.42.0, v1.43.0 Jan 24, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running the tests for this revealed we need to add the auth schema back in @tracypholmes

@tracypholmes tracypholmes requested a review from katbyte January 25, 2020 03:43
@tracypholmes tracypholmes requested a review from katbyte January 28, 2020 18:29
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @tracypholmes, this LGTM now 🚀

@tracypholmes tracypholmes merged commit 77ebbc4 into master Jan 29, 2020
@tracypholmes tracypholmes deleted the tph/ds-eventhub_namespace_auth_rule-new branch January 29, 2020 20:28
tracypholmes added a commit that referenced this pull request Jan 29, 2020
@ghost
Copy link

ghost commented Feb 4, 2020

This has been released in version 1.43.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.43.0"
}
# ... other configuration ...

@alastairtree
Copy link
Contributor

Thanks for this @tracypholmes

@ghost
Copy link

ghost commented Feb 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Feb 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add data source for azurerm_eventhub_namespace_authorization_rule
4 participants