Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading to v12.2.0-beta of the Azure SDK for Go #684

Merged
merged 3 commits into from
Jan 12, 2018

Conversation

tombuildsstuff
Copy link
Contributor

This is the first phase of upgrading to the Azure SDK for Go v12.2.0-beta. Once this is merged we can start moving Data Sources and Resources off the Deprecated SDKs and over to the versioned SDKs

Upgrades to:

@tombuildsstuff tombuildsstuff changed the title [WIP] Upgrading to v12.2.0-beta of the Azure SDK for Go Upgrading to v12.2.0-beta of the Azure SDK for Go Jan 11, 2018
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tombuildsstuff tombuildsstuff added this to the 1.0.2 milestone Jan 12, 2018
@dominik-lekse
Copy link
Contributor

That was quick, thanks for the upgrade.

@tombuildsstuff
Copy link
Contributor Author

@dominik-lekse alas this is only the first part - once this PR is merged I'll switch over to the versioned (e.g. not deprecated) SDK and then we should be good :)

@dominik-lekse
Copy link
Contributor

As far as I understood, the switch over to the versioned part of the SDK will be done per resource, right?

@tombuildsstuff
Copy link
Contributor Author

Tests look good - so I'm going to merge this to continue with part 2

@dominik-lekse probably, given the arm folder in the SDK gets removed next month I'm wondering if it's prudent just to do it in a few batches (I'll try migrating a few over and see how invasive it is - it may be prudent just to do it in one sweep, although that's less ideal for review reasons)

@tombuildsstuff tombuildsstuff merged commit 0437d99 into master Jan 12, 2018
@tombuildsstuff tombuildsstuff deleted the azure-sdk-v12 branch January 12, 2018 11:02
tombuildsstuff added a commit that referenced this pull request Jan 12, 2018
@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants