Support for more than two client certificate thumbprint sections for Azure Service Fabric Cluster

[viktors-telle]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Please add support for more than two client certificate thumbprint sections for the azurerm_service_fabric_cluster resource. Currently, you can add only two certificate thumbprints.

client_certificate_thumbprint - (Optional) One or two client_certificate_thumbprint blocks as defined below.

New or Affected Resource(s)

• azurerm_service_fabric_cluster

Potential Terraform Configuration

client_certificate_thumbprint {
    thumbprint        = ""
    is_admin          = true
}

client_certificate_thumbprint {
    thumbprint        = ""
    is_admin          = true
}

client_certificate_thumbprint {
    thumbprint        = ""
    is_admin          = true
}

...

References

https://www.terraform.io/docs/providers/azurerm/r/service_fabric_cluster.html#client_certificate_thumbprint

[neil-yechenwei]

Thanks for opening this issue. After tested, seems it works fine to create more than two client certificate thumbprints. So I made a fix for this issue. Hopes it would be helpful.

[viktors-telle]

Looks good to me, thank you for such a quick response!

[ghost]

This has been released in version 2.29.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.29.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!