New Resources: azurerm_network_interface_(backend_address_pool|nat_rule)_association
#2079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion` Tests pass: ``` $ acctests azurerm TestAccAzureRMNetworkInterfaceBackendAddressPoolAssociation_ === RUN TestAccAzureRMNetworkInterfaceBackendAddressPoolAssociation_basic --- PASS: TestAccAzureRMNetworkInterfaceBackendAddressPoolAssociation_basic (124.30s) === RUN TestAccAzureRMNetworkInterfaceBackendAddressPoolAssociation_deleted --- PASS: TestAccAzureRMNetworkInterfaceBackendAddressPoolAssociation_deleted (136.38s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 261.772s ```
Tests pass: ``` $ acctests azurerm TestAccAzureRMNetworkInterfaceNATRuleAssociation_ === RUN TestAccAzureRMNetworkInterfaceNATRuleAssociation_basic --- PASS: TestAccAzureRMNetworkInterfaceNATRuleAssociation_basic (467.52s) === RUN TestAccAzureRMNetworkInterfaceNATRuleAssociation_deleted --- PASS: TestAccAzureRMNetworkInterfaceNATRuleAssociation_deleted (119.26s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 588.211s ```
tombuildsstuff
force-pushed
the
f/subnet-lb-associations
branch
from
139e761 to
88d8f08
Compare
tombuildsstuff
commented
Oct 15, 2018
azurerm/provider.go
Outdated
| "azurerm_mysql_virtual_network_rule": resourceArmMySqlVirtualNetworkRule(), | ||
| "azurerm_network_interface": resourceArmNetworkInterface(), | ||
| "azurerm_network_interface_backend_address_pool_association": resourceArmNetworkInterfaceBackendAddressPoolAssociation(), | ||
| "azurerm_network_interface_nat_rule_association": resourceArmNetworkInterfaceNatRuleAssociation(), |
There was a problem hiding this comment.
@katbyte given we're doing a resource for application gateway associations too, I think this needs lb_ between network_interface and backend/nat- WDYT?
…address_pool_association`
|
Tests pass for this (without the new Application Gateway resource) - ignoring a known test failure:
|
katbyte
added a commit
that referenced
this pull request
Oct 16, 2018
dghubble
added a commit
to poseidon/typhoon
that referenced
this pull request
Oct 28, 2018
* Require terraform-provider-azurerm v1.17+ * Inline load_balancer_backend_address_pools_ids is deprecated and scheduled for removal in the v2.0 provider * hashicorp/terraform-provider-azurerm#2079
dghubble
added a commit
to poseidon/typhoon
that referenced
this pull request
Oct 28, 2018
* Require terraform-provider-azurerm v1.17+ * Inline load_balancer_backend_address_pools_ids is deprecated and scheduled for removal in the v2.0 provider * hashicorp/terraform-provider-azurerm#2079
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a few Virtual Resources for managing the relationship between an Application Gateway/Load Balancer and a Network Interface:
azurerm_network_interface_application_gateway_backend_address_pool_associationazurerm_network_interface_backend_address_pool_associationazurerm_network_interface_nat_rule_associationSince this is a Virtual Resource (and there's an existing field for managing this on the Network Interface resource) - that'll need to be deprecated as a part of 2.0
Fixes #880