Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding forwarding_configuration to front door #4404

Merged
merged 1 commit into from
Sep 23, 2019

Conversation

montross50
Copy link
Contributor

The docs did not include any information about this block. https://github.com/terraform-providers/terraform-provider-azurerm/blob/master/azurerm/resource_arm_front_door.go#L159

This should serve at least as a rough draft to make the docs more complete for this resource.

The docs did not include any information about this block. https://github.com/terraform-providers/terraform-provider-azurerm/blob/master/azurerm/resource_arm_front_door.go#L159 

This should serve at least as a rough draft to make the docs more complete for this resource.
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @montross50! LGTM 👍

@katbyte katbyte merged commit b4ecfeb into hashicorp:master Sep 23, 2019
@jrestall
Copy link

@montross50 @katbyte It would be useful to provide some guidance/docs on disabling caching as I'm currently researching how to do that with the front door provider.

It looks like based on the below, not providing a forwarding_configuration will automatically disable caching. Might be useful to confirm and document that.

https://github.com/Azure/azure-sdk-for-go/blob/master/services/preview/frontdoor/mgmt/2019-04-01/frontdoor/models.go#L927

It could be considered an issue that you can't disable caching and also use the forwarding_configuration if this is right though, would be better if cachingConfiguration wasn't set here if those two cache settings weren't set.

@ghost
Copy link

ghost commented Oct 4, 2019

This has been released in version 1.35.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.35.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants