From 0c9e37628b8d2c168f169e02c61f00f12dc37863 Mon Sep 17 00:00:00 2001 From: The Magician Date: Thu, 22 Jul 2021 12:05:51 -0500 Subject: [PATCH] Confusing environment variable with secrets in `google_cloud_run_service` documentation. (#4987) (#3440) * clarify cloudrun secret Co-authored-by: upodroid * Bit of formatting Co-authored-by: Cameron Thornton Signed-off-by: Modular Magician Co-authored-by: Cameron Thornton --- .changelog/4987.txt | 3 +++ google-beta/resource_cloud_run_service.go | 11 +++++------ website/docs/r/cloud_run_service.html.markdown | 11 +++++------ 3 files changed, 13 insertions(+), 12 deletions(-) create mode 100644 .changelog/4987.txt diff --git a/.changelog/4987.txt b/.changelog/4987.txt new file mode 100644 index 0000000000..8ec013c069 --- /dev/null +++ b/.changelog/4987.txt @@ -0,0 +1,3 @@ +```release-note:none + +``` diff --git a/google-beta/resource_cloud_run_service.go b/google-beta/resource_cloud_run_service.go index 44432685ef..dc7db39427 100644 --- a/google-beta/resource_cloud_run_service.go +++ b/google-beta/resource_cloud_run_service.go @@ -807,12 +807,11 @@ version or an integer for a specific version.`, Description: `The name of the secret in Cloud Secret Manager. By default, the secret is assumed to be in the same project. If the secret is in another project, you must define an alias. -An alias definition has the form: -:projects//secrets/. -If multiple alias definitions are needed, they must be separated by -commas. -The alias definitions must be set on the run.googleapis.com/secrets -annotation.`, +You set the in this field, and create an annotation with the +following structure +"run.googleapis.com/secrets" = ":projects//secrets/". +If multiple alias definitions are needed, they must be separated by +commas in the annotation field.`, }, }, }, diff --git a/website/docs/r/cloud_run_service.html.markdown b/website/docs/r/cloud_run_service.html.markdown index 0c61e9e724..f524a3a02d 100644 --- a/website/docs/r/cloud_run_service.html.markdown +++ b/website/docs/r/cloud_run_service.html.markdown @@ -769,12 +769,11 @@ The `secret_key_ref` block supports: The name of the secret in Cloud Secret Manager. By default, the secret is assumed to be in the same project. If the secret is in another project, you must define an alias. - An alias definition has the form: - :projects//secrets/. - If multiple alias definitions are needed, they must be separated by - commas. - The alias definitions must be set on the run.googleapis.com/secrets - annotation. + You set the in this field, and create an annotation with the + following structure + "run.googleapis.com/secrets" = ":projects//secrets/". + If multiple alias definitions are needed, they must be separated by + commas in the annotation field. The `ports` block supports: